fix: use DISABLE_V8_COMPILE_CACHE=1 so the designer can build via docker

[jenbutongit]

Note

This template is designed to help both contributors and maintainers. It is a checklist to ensure all necessary
information is provided, and prompts contributors on any contribution guidelines they have missed.

Do not remove sections.
They are important for the review process and help maintainers ensure quality and good documentation across the
project.

Some checkboxes will not apply to every change, so feel free to leave them unchecked if they are not relevant.

Description

Context

Builds of the docker designer image are failing, complaints seem to be from v8-compile-cache.

I haven't investigated why this error is happening now and whether or not this is due to an unpinned dep. I've tried upgrading to newer versions of node or yarn which doesn't seem to fix the issue. The fix I found is from a relatively old issue nodejs/corepack#342.

build error log

2.190     at Object.<anonymous> (/usr/src/app/node_modules/call-bind/index.js:3:25)
2.190     at Module._compile (/usr/src/app/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
2.190     at Module._extensions..js (node:internal/modules/cjs/loader:1623:10)
2.190     at Module.load (node:internal/modules/cjs/loader:1266:32)
2.190     at Module._load (node:internal/modules/cjs/loader:1091:12)
2.190     at Module.require (node:internal/modules/cjs/loader:1289:19)
2.190     at require (/usr/src/app/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
2.190     at Object.<anonymous> (/usr/src/app/node_modules/object.getownpropertydescriptors/index.js:4:16)

Changes

• Add ENV DISABLE_V8_COMPILE_CACHE=1 to docker build

Type of change

What is the type of change you are making?

• Chore or documentation (non-breaking change that does not add functionality)
• ADR (Architectural Decision Record, non-breaking change that documents or proposes a decision)
• Refactor (non-breaking change that improves code quality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR title

PR titles should be prefixed with the type of change you are making, based on the README.md#versioning.
This is so that when performing a squash merge, the PR title is automatically used as the commit message.

Have you updated the PR title to match the type of change you are making?

• Yes
• No, I need help or guidance

Testing

Automated tests

Have you added automated tests?

• Yes, unit or integration tests
• Yes, end-to-end (cypress) tests
• No, tests are not required for this change
• No, I need help or guidance
• No (explain why tests are not required or can't be added at this time)
  Not a change to src code/functionality.

Manual tests

Have you manually tested your changes?

• Yes
• No, manual tests are not required or sufficiently covered by automated tests

Have you attached an example form JSON or snippet for the reviewer in this PR?

• Yes
• No, any existing form can be used
• No, it is not required or not applicable

Steps to test

1. Checkout main
2. Run docker build -t designer:1363 -f designer/Dockerfile .
3. See same error as above

After checking out these changes

1. Run docker build -t designer:1363-fix -f designer/Dockerfile .
2. See that it doesn't fail
3. Run docker run -p 3000:3000 designer:1363-fix
4. Go to localhost:3000 to see the designer running

Documentation

Have you updated the documentation?

• Yes, I have updated ./docs for this change since additional explanation or steps to use/configure the feature is required
• Yes, I have added or updated an ADR for this change since it is large, complex, or has significant architectural implications
• Yes, I have added inline comments for hard-to-understand areas
• No, I am not sure if documentation is required
• No, documentation is not required for this change

Discussion

Warning

Large or complex changes may require discussion with the maintainers before they can be merged. If it has not yet been discussed, it may delay the review process

Have you discussed this change with the maintainers?

• Yes, I have discussed this change with the maintainers on slack, email or via GitHub issues
• Yes, this change is an ADR to help kick-off discussion
• No, this change is small and does not require discussion
• No, I am not sure if one is required