-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Get Started Walkthrough for Python #3299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aa74ce3 to
a8597a8
Compare
mDuo13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The big picture looks good and I confirmed that you can download and run the code sample, with the expected results, but I noticed a few inaccuracies that should be corrected.
a8597a8 to
bde516e
Compare
mDuo13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the build failure is probably unrelated to this PR. It does build successfully in local dev at least.
bde516e to
eb174b8
Compare
Preview here: https://xrpl-dev-portal--python-get-started-code-walkthrough.preview.redocly.app/docs/tutorials/python/build-apps/get-started