Skip to content

pbkit: Enable flip stall; expose ramin, print_char, depth buffer internals #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

pbkit: Enable flip stall; expose ramin, print_char, depth buffer internals #628

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ef762c8
pbkit: Expose ramin context registration.
abaire Nov 23, 2021
741fa13
pbkit: Expose depth buffer.
abaire Dec 1, 2021
ff765f7
Expose context registration.
abaire Dec 2, 2021
edaffee
Exposes pb_print_char to allow use of a full featured printf lib.
abaire Dec 20, 2021
02d7524
Enables flip stall in pbkit.
abaire May 3, 2022
83073d8
Adds sleep in pbkit exception handler to keep XBDM responsive.
abaire May 11, 2022
c05399a
pbkit: Support setting FB size multiplier
antangelo Feb 27, 2023
ec99083
Fix brace formatting
antangelo Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pbkit/pbkit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2468,7 +2468,7 @@ int pb_finished(void)
p=pb_push1(p,NV20_TCL_PRIMITIVE_3D_WAIT_MAKESPACE,0); //wait/makespace (obtains null status)
p=pb_push1(p,NV20_TCL_PRIMITIVE_3D_PARAMETER_A,pb_back_index); //set param=back buffer index to show up
p=pb_push1(p,NV20_TCL_PRIMITIVE_3D_FIRE_INTERRUPT,PB_FINISHED); //subprogID PB_FINISHED: gets frame ready to show up soon
// p=pb_push1(p,NV20_TCL_PRIMITIVE_3D_STALL_PIPELINE,0); //stall gpu pipeline (not sure it's needed in triple buffering technic)
p=pb_push1(p,NV20_TCL_PRIMITIVE_3D_STALL_PIPELINE,0); //stall gpu pipeline (not sure it's needed in triple buffering technic)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly it was just to mimic end of frame behavior observed in DirectX based titles in order to make tooling (like the pgraph tracer) simpler.

pb_end(p);

//insert in push buffer the commands to trigger selection of next back buffer
Expand Down