-
Notifications
You must be signed in to change notification settings - Fork 0
[QA] 여러 화면에서의 UI 오류 수정 #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
660de92
[BOOK-414] fix: replace deprecated assets
clxxrlove e7ed0ff
[BOOK-411] fix: apply missing font attributes in BKTextField
clxxrlove afbd727
[BOOK-411] fix: apply missing font attributes in BKTextView
clxxrlove 9e7e954
[BOOK-409] fix: correct incorrect UI layout/appearance in NoteAppreci…
clxxrlove eef2107
[BOOK-413] fix: unify back button insets app-wide
clxxrlove 40fbba2
[BOOK-413] feat: increase insets for better spacing in settings
clxxrlove 7650128
[BOOK-411] fix: update fonts in NoteEditView
clxxrlove 0cb20af
chore: bump project version to 1.2.0
clxxrlove d9f707a
[BOOK-425] chore: github actions workflow 개편
doyeonk429 a4d4173
[BOOK-411] fix: update fonts in NoteEditView.pageField
clxxrlove a9d810f
Merge branch 'develop' into BOOK-409-fix/#246
doyeonk429 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+24 Bytes
(110%)
...ssets/checkbox/checkbox-filled-rectangle.imageset/checkbox-filled-rectangle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+37 Bytes
(100%)
...ts/checkbox/checkbox-filled-rectangle.imageset/checkbox-filled-rectangle@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+12 Bytes
(100%)
...ts/checkbox/checkbox-filled-rectangle.imageset/checkbox-filled-rectangle@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-11 Bytes
(98%)
...Resources/Assets.xcassets/checkbox/checkbox-filled.imageset/checkbox-filled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+36 Bytes
(100%)
...ources/Assets.xcassets/checkbox/checkbox-filled.imageset/checkbox-filled@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+75 Bytes
(100%)
...ources/Assets.xcassets/checkbox/checkbox-filled.imageset/checkbox-filled@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(99%)
...ckbox-icononly_active-rectangle.imageset/checkbox-icononly_active-rectangle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(97%)
...ox-icononly_active-rectangle.imageset/checkbox-icononly_active-rectangle@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-16 Bytes
(98%)
...ox-icononly_active-rectangle.imageset/checkbox-icononly_active-rectangle@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2 Bytes
(99%)
...kbox/checkbox-icononly_active-round.imageset/checkbox-icononly_active-round.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-15 Bytes
(97%)
...x/checkbox-icononly_active-round.imageset/checkbox-icononly_active-round@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-16 Bytes
(98%)
...x/checkbox-icononly_active-round.imageset/checkbox-icononly_active-round@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-19 Bytes
(97%)
...ssets/checkbox/checkbox-stroke-rectangle.imageset/checkbox-stroke-rectangle.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+10 Bytes
(100%)
...ts/checkbox/checkbox-stroke-rectangle.imageset/checkbox-stroke-rectangle@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-5 Bytes
(100%)
...ts/checkbox/checkbox-stroke-rectangle.imageset/checkbox-stroke-rectangle@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+6 Bytes
(100%)
...sets.xcassets/checkbox/checkbox-stroke-round.imageset/checkbox-stroke-round.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-18 Bytes
(99%)
...s.xcassets/checkbox/checkbox-stroke-round.imageset/checkbox-stroke-round@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35 Bytes
(99%)
...s.xcassets/checkbox/checkbox-stroke-round.imageset/checkbox-stroke-round@3x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
백버튼 인셋 조정 확인
인셋 값이 -16에서 -8로 조정되고 imageWithOffset 변환이 제거되어 백버튼 위치가 더 표준에 가까워졌습니다. 이는 PR 목표인 백버튼 인셋 통일과 일치합니다.
다음 스크립트로 이 스타일을 사용하는 모든 화면에서 백버튼이 올바르게 렌더링되는지 확인하세요:
🏁 Script executed:
Length of output: 0
검색 결과가 없어 추가 검증이 필요합니다. 파일 내용과 변경 영향을 확인하겠습니다.
Length of output: 89
🏁 Script executed:
Length of output: 941
🏁 Script executed:
Length of output: 51
더 정확한 파일 내용 확인이 필요합니다.
Length of output: 1479
🏁 Script executed:
Length of output: 4455
Dead code 제거 필요: imageWithOffset 메서드는 사용되지 않습니다
Line 271의 인셋 조정은
configureBackButton메서드에 올바르게 통합되어 있으며 line 129에서 호출되어 활성화됩니다. 변경된 -8 좌측 인셋 값이 모든 표준 네비게이션 바에 일관되게 적용되어 PR 목표(백버튼 인셋 통일)가 달성됩니다.그러나 lines 353-361의
imageWithOffset메서드는 파일 내 어디에서도 호출되지 않는 dead code입니다. 이 메서드를 제거하여 코드를 정리하세요.🤖 Prompt for AI Agents