Handle unset ${HOME} gracefully
#79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmicko
force-pushed
the
main
branch
3 times, most recently
from
6eb5fb2 to
d02a272
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #75, we are having issues with Glasgow, where
${HOME}is forcibly unset - these scripts expect it to be set and get upset when trying to execute what resolves tomkdir /.config.The culmination of this PR is a fix to only set up the derived environment variables when
${HOME}is actually available - something that I believe is only really required for the UI component fo the toolchain anyway.I took the opportunity for some other enhancements too.