Skip to content

Conversation

@thelukewalton
Copy link
Contributor

@thelukewalton thelukewalton commented Apr 3, 2025

Allow users to use whatever package manager they want i.e. yarn

ci: Update PR script
deps: Update npm dependencies

@thelukewalton thelukewalton requested review from DE7924 and Copilot April 3, 2025 15:40
@DE7924
Copy link
Collaborator

DE7924 commented Apr 3, 2025

PR Checks Complete

✅ Analysis

✅ Formatting

✅ Testing

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the npm install stage from both the GitHub action and the related code, allowing users to choose their preferred package manager. Key changes include the removal of the npm installation parameter and related code in src/scripts/comment.ts and src/main.ts, and updating the workflow documentation in README.md.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/scripts/comment.ts Removed the npm installation parameter and its usage; added an explicit type for comment.
src/main.ts Removed the npm install command call, aligning with the removal of the npm installation stage.
README.md Updated the workflow to use "npm ci" for dependencies, but may need adjustment for alternative package managers.
Comments suppressed due to low confidence (1)

src/scripts/comment.ts:108

  • [nitpick] Using 'any' for the comment parameter may reduce type safety; consider defining a more specific type if one is available.
const comment = comments.find((comment: any) =>

@ZebraDevs ZebraDevs deleted a comment from Copilot AI Apr 3, 2025
@thelukewalton thelukewalton merged commit 6ec04b0 into main Apr 4, 2025
6 checks passed
@thelukewalton thelukewalton deleted the chore/npm branch April 4, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants