Skip to content

UN-2865 [FIX] Remove premature COMPLETED status update in general worker after async file orchestration #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2025
Merged

UN-2865 [FIX] Remove premature COMPLETED status update in general worker after async file orchestration #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions workers/general/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from shared.data.models import (
CallbackTaskData,
WorkerTaskResponse,
WorkflowExecutionStatusUpdate,
)
from shared.enums.status_enums import PipelineStatus
from shared.enums.task_enums import TaskName
Expand Down Expand Up @@ -270,24 +269,14 @@ def async_execute_bin_general(
**kwargs,
)

# Calculate execution time
# Calculate orchestration time (not total execution time - callback worker calculates that)
execution_time = execution_result.get("execution_time", 0)

# Update execution status to completed
# Only include total_files if we have files to avoid overwriting with 0
update_request = WorkflowExecutionStatusUpdate(
execution_id=execution_id,
status=ExecutionStatus.COMPLETED.value,
execution_time=execution_time,
total_files=len(hash_values_of_files) if hash_values_of_files else None,
)

api_client.update_workflow_execution_status(**update_request.to_dict())

# Status remains EXECUTING - callback worker will set COMPLETED/ERROR after all files finish
# Cache cleanup handled by callback worker

logger.info(
f"Successfully completed general workflow execution {execution_id}"
f"Successfully orchestrated general workflow execution {execution_id} (files processing asynchronously)"
)

response = WorkerTaskResponse.success_response(
Expand Down