When element's nodetype is 9 return empty string instead of throwing error. #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much. Could you give me a test case where this problem is happening? |
|
I am getting this error in one of our private project where we are including a lot of js files, I haven't been able to isolate whats the exact case when this error is happening but I doubt this is happening when we use lazysizes.js with jquery-migrate.min.js. If i'm able to isolate i'll post it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was constantly getting following error:
Failed to execute 'getComputedStyle' on 'Window': parameter is not of type 'Element'
and I solved it using this solution.