-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Improve cache service availability determination and change failure log levels #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
11
commits into
main
Choose a base branch
from
copilot/fix-2099
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+170
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to errors - Update isFeatureAvailable() to leverage ACTIONS_CACHE_SERVICE_V2 feature flag - For v2: check ACTIONS_RESULTS_URL availability - For v1: check either ACTIONS_CACHE_URL or ACTIONS_RESULTS_URL availability - Change warning logs to error logs for cache failures - Add comprehensive tests covering all scenarios Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
- Update restoreCacheV2.test.ts, restoreCache.test.ts, saveCacheV2.test.ts, and saveCache.test.ts - Change test expectations from core.warning to core.error for cache operation failures - All tests now pass successfully Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Copilot finished work on behalf of
Link-
July 14, 2025 10:40
Link-
requested changes
Jul 14, 2025
…ailures Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Link-
requested changes
Jul 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the implementation as per the comments provided
Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Link-
reviewed
Jul 14, 2025
Link-
reviewed
Jul 14, 2025
…n as requested Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Implemented as requested in commit d48d6b6. Removed the logCacheError function and added inline 5xx server error detection in all four cache functions. |
Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Copilot finished work on behalf of
Link-
July 14, 2025 13:01
Copilot finished work on behalf of
Link-
July 14, 2025 13:18
Link-
reviewed
Jul 14, 2025
Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Copilot finished work on behalf of
Link-
July 14, 2025 13:39
Link-
reviewed
Jul 14, 2025
Co-authored-by: Link- <568794+Link-@users.noreply.github.com>
Copilot finished work on behalf of
Link-
July 14, 2025 13:50
BoomchainLabs
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how the cache service availability is determined in
@actions/toolkit
and changes the log level of cache failures from warnings to errors.Changes Made
1. Enhanced
isFeatureAvailable()
functionThe
isFeatureAvailable()
function now properly leverages theACTIONS_CACHE_SERVICE_V2
feature flag to determine cache service availability:ACTIONS_RESULTS_URL
to be setACTIONS_CACHE_URL
orACTIONS_RESULTS_URL
to be setBefore:
After:
2. Changed log levels from warnings to errors
Updated all cache failure logs from
core.warning()
tocore.error()
in:restoreCacheV1()
functionrestoreCacheV2()
functionsaveCacheV1()
functionsaveCacheV2()
function3. Comprehensive test coverage
Added extensive test coverage including:
Exit Criteria Met
✅ Even if
ACTIONS_CACHE_URL
is not set,isFeatureAvailable()
now uses alternative ways to determine cache service availability✅ Changed log level of cache failures from warning to error
Backward Compatibility
This change maintains full backward compatibility:
ACTIONS_CACHE_URL
continue to work unchangedFixes #2099.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.