feat: Skip the Kalman fitter on the first CKF step

[niermann999]

Since it just retrieves the first measurement of the seed, the first Kalman gain matrix call can be skipped

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298345 (+0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50185 to 50194 (+0.0%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	a244e2d	703ac82	Delta	a244e2d	703ac82
propagate_to_next_surface	8.39 ms	8.37 ms	-0.2%	3.48	3.49
fit_backward	2.55 ms	2.55 ms	0.1%	7.34	7.33
fit_forward	1.99 ms	1.99 ms	0.3%	7.34	7.34
find_tracks	1.39 ms	1.16 ms	-16.3%	1.81	1.86
ccl_kernel	823.85 μs	824.51 μs	0.1%	1.37	1.37
count_doublets	628.35 μs	617.58 μs	-1.7%	1.61	1.61
count_triplets	590.86 μs	588.64 μs	-0.4%	1.02	1.02
find_doublets	451.25 μs	450.01 μs	-0.3%	3.08	3.08
Thrust::sort	384.93 μs	385.04 μs	0.0%	7.36	7.36
find_triplets	173.41 μs	171.75 μs	-1.0%	1.31	1.32
select_seeds	53.48 μs	53.33 μs	-0.3%	1.34	1.34
remove_duplicates	23.60 μs	23.56 μs	-0.2%	26.10	26.08
populate_grid	23.49 μs	23.45 μs	-0.2%	1.22	1.22
count_grid_capacities	22.22 μs	22.20 μs	-0.1%	1.22	1.22
fill_sorted_measurements	19.71 μs	19.74 μs	0.2%	1.13	1.13
update_triplet_weights	15.05 μs	15.11 μs	0.4%	1.27	1.27
apply_interaction	14.26 μs	14.26 μs	-0.0%	6.72	6.71
estimate_track_params	14.22 μs	14.25 μs	0.2%	2.15	2.15
fit_prelude	9.80 μs	9.81 μs	0.1%	21.77	21.78
fill_finding_propagation_sort_keys	8.84 μs	8.85 μs	0.2%	7.61	7.59
form_spacepoints	7.86 μs	7.85 μs	-0.2%	1.48	1.48
reduce_triplet_counts	6.28 μs	6.28 μs	-0.0%	3.08	3.08
unknown	5.04 μs	5.05 μs	0.2%	4.28	4.27
build_tracks	4.12 μs	4.11 μs	-0.1%	14.78	14.77
fill_finding_duplicate_removal_sort_keys	1.57 μs	1.57 μs	0.2%	37.97	37.93
fill_prefix_sum	172.00 ns	171.98 ns	-0.0%	341.30	341.30
fill_fitting_sort_keys	153.43 ns	153.56 ns	0.1%	22.08	22.08
Total	17.59 ms	17.34 ms	-1.4%	4.19	4.22

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	a244e2d	0de875c	Delta	a244e2d	0de875c
propagate_to_next_surface	8.38 ms	8.33 ms	-0.5%	3.49	3.45
fit_backward	2.55 ms	2.16 ms	-15.1%	7.34	7.83
fit_forward	1.98 ms	1.77 ms	-10.5%	7.35	7.83
find_tracks	1.38 ms	1.15 ms	-16.9%	1.81	1.90
ccl_kernel	826.14 μs	825.59 μs	-0.1%	1.37	1.37
count_doublets	623.83 μs	624.21 μs	0.1%	1.61	1.61
count_triplets	590.41 μs	591.80 μs	0.2%	1.02	1.02
find_doublets	446.30 μs	445.42 μs	-0.2%	3.08	3.08
Thrust::sort	384.70 μs	384.16 μs	-0.1%	7.36	7.34
find_triplets	172.58 μs	171.77 μs	-0.5%	1.31	1.31
select_seeds	53.48 μs	53.75 μs	0.5%	1.34	1.34
populate_grid	23.48 μs	23.46 μs	-0.1%	1.22	1.22
remove_duplicates	23.58 μs	22.60 μs	-4.2%	26.06	27.03
count_grid_capacities	22.16 μs	22.18 μs	0.1%	1.22	1.22
fill_sorted_measurements	19.80 μs	19.78 μs	-0.1%	1.13	1.13
update_triplet_weights	15.06 μs	14.98 μs	-0.5%	1.27	1.27
estimate_track_params	14.27 μs	14.30 μs	0.2%	2.15	2.15
apply_interaction	14.26 μs	14.15 μs	-0.8%	6.72	6.72
fit_prelude	9.85 μs	8.76 μs	-11.0%	21.80	23.26
fill_finding_propagation_sort_keys	8.86 μs	8.76 μs	-1.1%	7.60	7.62
form_spacepoints	7.94 μs	7.92 μs	-0.3%	1.49	1.48
reduce_triplet_counts	6.29 μs	6.28 μs	-0.2%	3.08	3.08
unknown	5.06 μs	5.05 μs	-0.1%	4.27	4.28
build_tracks	4.10 μs	3.89 μs	-5.0%	14.78	15.83
fill_finding_duplicate_removal_sort_keys	1.57 μs	1.50 μs	-4.6%	37.93	39.45
fill_prefix_sum	171.94 ns	171.97 ns	0.0%	341.30	341.30
fill_fitting_sort_keys	152.73 ns	143.43 ns	-6.1%	22.11	23.56
Total	17.56 ms	16.69 ms	-5.0%	4.19	4.22

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298342 (-0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50179 to 47951 (-4.4%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.

[stephenswat]

Performance summary

Here is a summary of the performance effects of this PR:

Graphical

Tabular

Kernel	Reciprocal Throughput			Parallelism
	a244e2d	66ac85b	Delta	a244e2d	66ac85b
propagate_to_next_surface	8.39 ms	8.46 ms	0.9%	3.48	3.57
fit_backward	2.54 ms	2.58 ms	1.4%	7.34	7.14
fit_forward	1.98 ms	2.14 ms	7.8%	7.34	7.14
find_tracks	1.38 ms	1.43 ms	3.8%	1.81	1.81
ccl_kernel	824.33 μs	824.09 μs	-0.0%	1.37	1.37
count_doublets	625.34 μs	618.70 μs	-1.1%	1.61	1.61
count_triplets	590.36 μs	588.27 μs	-0.4%	1.02	1.02
find_doublets	449.16 μs	446.93 μs	-0.5%	3.07	3.08
Thrust::sort	384.97 μs	385.55 μs	0.2%	7.36	7.39
find_triplets	172.12 μs	172.01 μs	-0.1%	1.32	1.31
select_seeds	53.66 μs	53.22 μs	-0.8%	1.34	1.34
remove_duplicates	23.62 μs	24.16 μs	2.3%	26.09	25.42
populate_grid	23.44 μs	23.46 μs	0.1%	1.22	1.22
count_grid_capacities	22.59 μs	22.19 μs	-1.8%	1.22	1.22
fill_sorted_measurements	19.77 μs	19.84 μs	0.3%	1.13	1.13
update_triplet_weights	15.08 μs	15.16 μs	0.5%	1.27	1.27
apply_interaction	14.40 μs	14.36 μs	-0.3%	6.73	6.75
estimate_track_params	14.24 μs	14.32 μs	0.6%	2.15	2.15
fit_prelude	9.83 μs	10.68 μs	8.7%	21.77	21.24
fill_finding_propagation_sort_keys	8.82 μs	8.97 μs	1.6%	7.62	7.60
form_spacepoints	7.97 μs	7.92 μs	-0.6%	1.48	1.48
reduce_triplet_counts	6.33 μs	6.30 μs	-0.5%	3.08	3.08
unknown	5.05 μs	5.07 μs	0.4%	4.27	4.27
build_tracks	4.10 μs	4.28 μs	4.5%	14.76	14.47
fill_finding_duplicate_removal_sort_keys	1.56 μs	1.61 μs	3.2%	38.14	37.32
fill_prefix_sum	171.89 ns	171.88 ns	-0.0%	341.30	341.30
fill_fitting_sort_keys	152.61 ns	157.67 ns	3.3%	22.08	21.48
Total	17.57 ms	17.87 ms	1.7%	4.18	4.20

Important

All metrics in this report are given as reciprocal throughput, not as wallclock runtime.

Note

This is an automated message produced upon the explicit request of a human being.

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298345 to 298342 (-0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50179 to 50478 (+0.6%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.

[sonarqubecloud]

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[stephenswat]

Physics performance summary

Here is a summary of the physics performance effects of this PR. Command used:

traccc_seeding_example_cuda --input-directory=/data/Acts/odd-simulations-20240506/geant4_ttbar_mu200 --digitization-file=geometries/odd/odd-digi-geometric-config.json --detector-file=geometries/odd/odd-detray_geometry_detray.json --grid-file=geometries/odd/odd-detray_surface_grids_detray.json --material-file=geometries/odd/odd-detray_material_detray.json --input-events=10 --use-acts-geom-source=on --check-performance --truth-finding-min-track-candidates=5 --truth-finding-min-pt=1.0 --truth-finding-min-z=-150 --truth-finding-max-z=150 --truth-finding-max-r=10 --seed-matching-ratio=0.99 --track-matching-ratio=0.5 --track-candidates-range=5:100 --seedfinder-vertex-range=-150:150

Seeding performance

Total number of seeds went from 298342 to 298341 (-0.0%)

Seeding plots

Track finding performance

Total number of found tracks went from 50190 to 50252 (+0.1%)

Finding plots

Track fitting performance

Fitting plots

Seeding to track finding relative performance

Seeding to track finding plots

Track finding to track fitting relative performance

Track finding to track fitting plots

Note

This is an automated message produced on the explicit request of a human being.