Remove graphql as peer dependency #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt@popsql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes
graphqlas a peer dependency from this module.graphqlis not used directly within this module, so having it as a peer dependency doesn't really make much sense, and it's already a peer dependency for@apollo/client(which does actively need it) so from an end-user's perspective, they'll still be appropriately warned if they're missing it, granted it'll be one level more nested in the warning.This resolves the issue for us where we get a peer dependency warning that
next-apollodoes not supportgraphql@^16.0.0and while could add that version here, it's effectively meaningless since it's really what@apollo/clientsupports and not this library.