Skip to content

Set aria-hidden on div in ResizeHandle #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maniekpl00
Copy link
Contributor

@maniekpl00 maniekpl00 commented Aug 1, 2025

Added aria-hidden="true" to the inner div used for column resizing.
This prevents VoiceOver from reading the column header twice while keeping resize functionality available for mouse users.

Tested environment

  • MacOS, Voiceover

Before

Screen.Recording.2025-08-01.at.20.31.05.mov

After

Screen.Recording.2025-08-01.at.20.31.44.mov

Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR

@amanmahajan7
Copy link
Contributor

@maniekpl00 please us know if you notice any other accessibility issues. We can use some feedback

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.61%. Comparing base (d64808a) to head (087c60f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3834   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          46       46           
  Lines        3611     3612    +1     
  Branches      773      773           
=======================================
+ Hits         3561     3562    +1     
  Misses         50       50           
Files with missing lines Coverage Δ
src/HeaderCell.tsx 97.81% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amanmahajan7 amanmahajan7 merged commit adbee84 into adazzle:main Aug 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants