Skip to content

Conversation

@youbek
Copy link
Collaborator

@youbek youbek commented Dec 15, 2025

Main changes

  • updates push notification delivery. It now uses official adcp python library for creating payloads depending on the protocol.
  • It fixes creative approval/rejection to be fully aligned with adcp protocol.
  • It fixes sending correct status when manual approval is required. Previously it was sending completed statuses even the media buy required approval. It led bugs where buyer recieved completed result whereas it was still pending approval on the sales agent part

Related PRs

Demo Looms (MCP)

Demo Looms (A2A)

I have read the IPR Policy

@youbek youbek self-assigned this Dec 15, 2025
@youbek youbek marked this pull request as draft December 15, 2025 19:06
@youbek youbek changed the title feat: update webhook delivery function to support both mcp and a2a pa… feat: update webhook delivery function to support both mcp and a2a payloads Dec 15, 2025
@gitguardian
Copy link

gitguardian bot commented Dec 15, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@youbek youbek marked this pull request as ready for review December 17, 2025 15:15
@youbek youbek force-pushed the feat/update-webhook-delivery branch from cb17986 to 880479f Compare December 17, 2025 15:57
Copy link
Collaborator

@BaiyuScope3 BaiyuScope3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

IPR Policy Agreement Required

Thank you for your contribution! Before we can accept your pull request, you must agree to our Intellectual Property Rights Policy.

By making a Contribution, you agree that:

  • You grant the Foundation a perpetual, irrevocable, worldwide, non-exclusive, royalty-free copyright license to your Contribution
  • You grant a patent license under any Necessary Claims
  • You represent that you own or have sufficient rights to grant these licenses

To agree, please comment below with the exact phrase:

I have read the IPR Policy

You can read the full IPR Policy here.


I have read the IPR Policy


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@youbek youbek force-pushed the feat/update-webhook-delivery branch 2 times, most recently from 5266792 to 62e0140 Compare January 2, 2026 05:15
@youbek youbek force-pushed the feat/update-webhook-delivery branch from 62e0140 to 8050605 Compare January 4, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants