Skip to content

Add ability to open menu items in a new tab #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmd05
Copy link

@cmd05 cmd05 commented Feb 3, 2025

What does this PR change? What problem does it solve?

Add the ability to open specific menu items in a new tab. When an identifier begins with "ext-", it will add a target="_blank". This is independent of whether the link is an external link, so the user can decide themselves. For example, if I want to make my blog page open in a new tab:

menu:
  main:
    - identifier: "ext-blog"
      name: Blog
      url: /blog/
      # or url: https://blogsite.com 
      weight: 1

Was the change discussed in an issue or in the Discussions before?

Inspired by this PR

This discussion to open all external links in a new tab.
Hugo still has not implemented target parameter for menu items. Issue

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

sonarqubecloud bot commented Feb 3, 2025

@rickeygong
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants