Skip to content

Conversation

@yihuiliao
Copy link
Member

Closes #8354

Tested it with VO before and after this change and it didn't really make a difference in terms of announcement. It always seemed to announce it as a group so I feel like this change is fine and now won't violate accessibility.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Aug 13, 2025

@rspbot
Copy link

rspbot commented Aug 13, 2025

@yihuiliao yihuiliao added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit 42e5a2c Aug 15, 2025
32 checks passed
@yihuiliao yihuiliao deleted the empty-taggroup-role branch August 15, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TagGroup doesn't add role attr when collection is empty

5 participants