Skip to content

fix: Combobox VoiceOver announcement not respecting aria-label of ListBoxItem #8908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2025
+25 −0
Merged

fix: Combobox VoiceOver announcement not respecting aria-label of ListBoxItem #8908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
189e8a6
add ComboBox Story for ListBoxItem with aria-label
SimonSelg Sep 23, 2025
7e694f6
fix `CollectionBuilder` to handle `aria-label` correctly
SimonSelg Sep 23, 2025
5cb7760
Merge branch 'main' into fix-combobox-item-aria-label
snowystinger Oct 6, 2025
002423a
only add key if it exists
snowystinger Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@react-aria/collections/src/Document.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,9 @@ export class ElementNode<T> extends BaseNode<T> {
node.rendered = rendered;
node.render = render;
node.value = value;
if (obj['aria-label']) {
node['aria-label'] = obj['aria-label'];
}
node.textValue = textValue || (typeof props.children === 'string' ? props.children : '') || obj['aria-label'] || '';
if (id != null && id !== node.key) {
throw new Error('Cannot change the id of an item');
Expand Down
22 changes: 22 additions & 0 deletions packages/react-aria-components/stories/ComboBox.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,3 +367,25 @@ export function WithCreateOption() {
</ComboBox>
);
}

export const ComboBoxListBoxItemWithAriaLabel: ComboBoxStory = () => (
<ComboBox name="combo-box-example" data-testid="combo-box-example" allowsEmptyCollection>
<Label style={{display: 'block'}}>Test</Label>
<div style={{display: 'flex'}}>
<Input />
<Button>
<span aria-hidden="true" style={{padding: '0 2px'}}>▼</span>
</Button>
</div>
<Popover placement="bottom end">
<ListBox
renderEmptyState={renderEmptyState}
data-testid="combo-box-list-box"
className={styles.menu}>
<MyListBoxItem aria-label="Item Foo" textValue="Foo">Item <b>Foo</b></MyListBoxItem>
<MyListBoxItem aria-label="Item Bar" textValue="Bar">Item <b>Bar</b></MyListBoxItem>
<MyListBoxItem aria-label="Item Baz" textValue="Baz">Item <b>Baz</b></MyListBoxItem>
</ListBox>
</Popover>
</ComboBox>
);