Skip to content

Conversation

@yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Sep 25, 2025

Closes #8924

Reverts #8573, reverts everything except for the isScrolling

@nwidynski We've chosen to revert the above PR due to some issues with the native scrollend event not being fired in certain use cases. For now, this is the easiest fix but we do realize that the root problem hasn't been addressed

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@nwidynski
Copy link
Contributor

nwidynski commented Sep 25, 2025

@yihuiliao Do you know which part of the code is responsible for scrolling the popover after deleting a collection element? I have a hunch the underlying issue could be due to the way we mutate scrollTop = <value> instead of calling scrollTo, which also caused other issues in the past (see #8715 (comment))

@devongovett devongovett added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 02cc874 Sep 26, 2025
33 checks passed
@devongovett devongovett deleted the scroll-bug branch September 26, 2025 01:09
@yihuiliao
Copy link
Member Author

@nwidynski Sorry for the late reply. I'm not entirely sure what is responsible for scrolling the popover when part of the input is deleted. I would have thought it was maybe scrollIntoView but it seems that doesn't get called which would be related to useSelectableCollection.

I'll continue to dig when I have time but I'm not the most familiar with the scroll position stuff unfortunately 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox type ahead results not clickable with mouse

5 participants