fix: EditableTable Cells from testing feedback #9108
+649
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
changed the title
|
Build successful! 🎉 |
LFDanLu
reviewed
Oct 29, 2025
| }; | ||
|
|
||
| // Can't differentiate between Dialog click outside dismissal and Escape key dismissal | ||
| let isMobile = !useMediaQuery('(any-pointer: fine)'); |
There was a problem hiding this comment.
this doesn't seem to trigger for Android, might need to use touch: '@media not ((hover: hover) and (pointer: fine))', which is what the style macro uses
Comment on lines
1227
to
1242
| useEffect(() => { | ||
| let dialog = dialogRef.current?.UNSAFE_getDOMNode(); | ||
| if (isOpen && dialog) { | ||
| let handler = (e: KeyboardEvent) => { | ||
| if (e.key === 'Escape') { | ||
| setIsOpen(false); | ||
| e.stopPropagation(); | ||
| e.preventDefault(); | ||
| } | ||
| }; | ||
| dialog.addEventListener('keydown', handler); | ||
| return () => { | ||
| dialog.removeEventListener('keydown', handler); | ||
| }; | ||
| } | ||
| }, [isOpen]); |
There was a problem hiding this comment.
Thats a bit annoying that this needs to be done since dismissible dialogs close on touch start I assume... Feels like a relatively common use case too, wonder if we could support this by default
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:EditableCell EditableCell {
+ action?: string | FormHTMLAttributes<HTMLFormElement>['action']
align?: 'start' | 'center' | 'end' = 'start'
children: ReactNode
colSpan?: number
id?: Key
isSaving?: boolean
- onSubmit: () => void
+ onCancel?: () => void
+ onSubmit?: (FormEvent<HTMLFormElement>) => void
renderEditing: () => ReactNode
showDivider?: boolean
textValue?: string
}@react-stately/data/@react-stately/data:ListData ListData <T> {
addKeysToSelection: (Selection) => void
append: (Array<T>) => void
filterText: string
getItem: (Key) => T | undefined
insert: (number, Array<T>) => void
insertAfter: (Key, Array<T>) => void
insertBefore: (Key, Array<T>) => void
items: Array<T>
move: (Key, number) => void
moveAfter: (Key, Iterable<Key>) => void
moveBefore: (Key, Iterable<Key>) => void
prepend: (Array<T>) => void
remove: (Array<Key>) => void
removeKeysFromSelection: (Selection) => void
removeSelectedItems: () => void
selectedKeys: Selection
setFilterText: (string) => void
setSelectedKeys: (Selection) => void
- update: (Key, T) => void
+ update: (Key, T | (T) => T) => void
}/@react-stately/data:AsyncListData AsyncListData <T> {
addKeysToSelection: (Selection) => void
append: (Array<T>) => void
error?: Error
filterText: string
getItem: (Key) => T | undefined
insert: (number, Array<T>) => void
insertAfter: (Key, Array<T>) => void
insertBefore: (Key, Array<T>) => void
isLoading: boolean
items: Array<T>
loadMore: () => void
loadingState: LoadingState
move: (Key, number) => void
moveAfter: (Key, Iterable<Key>) => void
moveBefore: (Key, Iterable<Key>) => void
prepend: (Array<T>) => void
reload: () => void
remove: (Array<Key>) => void
removeKeysFromSelection: (Selection) => void
removeSelectedItems: () => void
selectedKeys: Selection
setFilterText: (string) => void
setSelectedKeys: (Selection) => void
sort: (SortDescriptor) => void
sortDescriptor?: SortDescriptor
- update: (Key, T) => void
+ update: (Key, T | (T) => T) => void
} |
snowystinger
commented
Nov 3, 2025
| * @param newValue - The new value for the item, or a function that returns the new value based on the previous value. | ||
| */ | ||
| update(key: Key, newValue: T): void | ||
| update(key: Key, newValue: T | ((prev: T) => T)): void |
There was a problem hiding this comment.
This works like useState's setState callback, we already had the previous value, so it was trivial to expose and it simplified my logic in my examples, no longer have to track the previous list state and depend on renders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
This changes from the popover to a true dialog for touch devices where a keyboard may come into view and mess with the scroll position.
It removes the intermediate ref from the examples and uses the form submission to track updated values.
Adds aria labels and better label examples.
Removes inverted row hover color.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: