Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Nov 7, 2025

Description

Adds typesVersions mapping to @spectrum-web-components/core package.json to improve TypeScript type resolution compatibility, particularly for users with moduleResolution: "node" or older TypeScript versions.

https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#version-selection-with-typesversions

Motivation and context

After the monorepo restructure in v1.10.0, some customers using moduleResolution: "node" with skipLibCheck: false reported TypeScript compilation errors when the type resolution chain passes through the core package.

The typesVersions field provides a fallback mechanism for TypeScript to locate declaration files when the standard exports field resolution encounters issues. This improves compatibility across different TypeScript configurations and versions.
From my brief investigation, typesVersions works because it provides explicit path mappings for TypeScript to find .d.ts files, works as a fallback when exports resolution is incomplete and supports older TypeScript versions that don't fully understand exports field. So this seems defensive enough.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Test with snapshot release
  • Create a snapshot release: yarn publish:snapshot
  • Install the snapshot in a test project with strict TypeScript settings:
       {
         "compilerOptions": {
           "moduleResolution": "node",
           "skipLibCheck": false
         }
       }

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: 0655d8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 80 packages
Name Type
@spectrum-web-components/core Patch
@spectrum-web-components/base Patch
@spectrum-web-components/alert-banner Patch
@spectrum-web-components/asset Patch
@spectrum-web-components/badge Patch
@spectrum-web-components/divider Patch
@spectrum-web-components/progress-circle Patch
@spectrum-web-components/status-light Patch
@spectrum-web-components/theme Patch
@adobe/swc Patch
@spectrum-web-components/accordion Patch
@spectrum-web-components/action-bar Patch
@spectrum-web-components/action-button Patch
@spectrum-web-components/action-group Patch
@spectrum-web-components/action-menu Patch
@spectrum-web-components/alert-dialog Patch
@spectrum-web-components/avatar Patch
@spectrum-web-components/breadcrumbs Patch
@spectrum-web-components/button-group Patch
@spectrum-web-components/button Patch
@spectrum-web-components/card Patch
@spectrum-web-components/checkbox Patch
@spectrum-web-components/clear-button Patch
@spectrum-web-components/close-button Patch
@spectrum-web-components/coachmark Patch
@spectrum-web-components/color-area Patch
@spectrum-web-components/color-field Patch
@spectrum-web-components/color-handle Patch
@spectrum-web-components/color-loupe Patch
@spectrum-web-components/color-slider Patch
@spectrum-web-components/color-wheel Patch
@spectrum-web-components/combobox Patch
@spectrum-web-components/contextual-help Patch
@spectrum-web-components/dialog Patch
@spectrum-web-components/dropzone Patch
@spectrum-web-components/field-group Patch
@spectrum-web-components/field-label Patch
@spectrum-web-components/help-text Patch
@spectrum-web-components/icon Patch
@spectrum-web-components/icons-ui Patch
@spectrum-web-components/icons-workflow Patch
@spectrum-web-components/icons Patch
@spectrum-web-components/iconset Patch
@spectrum-web-components/illustrated-message Patch
@spectrum-web-components/infield-button Patch
@spectrum-web-components/link Patch
@spectrum-web-components/menu Patch
@spectrum-web-components/meter Patch
@spectrum-web-components/modal Patch
@spectrum-web-components/number-field Patch
@spectrum-web-components/overlay Patch
@spectrum-web-components/picker-button Patch
@spectrum-web-components/picker Patch
@spectrum-web-components/popover Patch
@spectrum-web-components/progress-bar Patch
@spectrum-web-components/radio Patch
@spectrum-web-components/search Patch
@spectrum-web-components/sidenav Patch
@spectrum-web-components/slider Patch
@spectrum-web-components/split-view Patch
@spectrum-web-components/swatch Patch
@spectrum-web-components/switch Patch
@spectrum-web-components/table Patch
@spectrum-web-components/tabs Patch
@spectrum-web-components/tags Patch
@spectrum-web-components/textfield Patch
@spectrum-web-components/thumbnail Patch
@spectrum-web-components/toast Patch
@spectrum-web-components/tooltip Patch
@spectrum-web-components/top-nav Patch
@spectrum-web-components/tray Patch
@spectrum-web-components/underlay Patch
@spectrum-web-components/bundle Patch
@spectrum-web-components/grid Patch
@spectrum-web-components/opacity-checkerboard Patch
@spectrum-web-components/shared Patch
@spectrum-web-components/styles Patch
@spectrum-web-components/truncated Patch
@spectrum-web-components/reactive-controllers Patch
@spectrum-web-components/eslint-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5866

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@rubencarvalho rubencarvalho marked this pull request as ready for review November 7, 2025 13:19
@rubencarvalho rubencarvalho requested a review from a team as a code owner November 7, 2025 13:19
@TarunAdobe TarunAdobe force-pushed the ruben/fix-node-types-resolution branch from 42cb9fe to 12ff023 Compare November 10, 2025 06:31
@Rajdeepc Rajdeepc merged commit 9cb816b into main Nov 13, 2025
22 checks passed
@Rajdeepc Rajdeepc deleted the ruben/fix-node-types-resolution branch November 13, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants