Skip to content

Conversation

@caseyisonit
Copy link
Contributor

@caseyisonit caseyisonit commented Nov 11, 2025

Description

Generate a PR review link for the 2ng-gen storybook to aid in PR reviews

Motivation and context

Currently all work being done in 2nd-gen requires reviewers to check out the PR and run everything locally. This PR will publish a review link similar to 1st-gen and improves the PR comment to make it explicit which generation the links associate to.

Related issue(s)

  • fixes [Issue Number]

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Confirm PR comment works

    1. See first gen and second gen links in the PR comment below

@caseyisonit caseyisonit requested a review from a team as a code owner November 11, 2025 18:33
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025

⚠️ No Changeset found

Latest commit: ab65283

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@adobe adobe deleted a comment from github-actions bot Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

📚 Branch Preview Links

🔍 First Generation Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5875

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@caseyisonit caseyisonit added Tooling Issue or PR dealing with scripts, workflows, automation, etc Status: Ready for review PR ready for review or re-review. labels Nov 11, 2025
Copy link
Contributor

@TarunAdobe TarunAdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with merging this but i suppose in future it would be better to have separate workflows for first-gen and second-gen and isolate the scripts? Even different comments maybe idk... it's subjective

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just questions for you! ❓

pull_request:
types: [opened, synchronize, reopened, closed]
branches:
- '**'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the preview docs action was failing because of all of the whitespace/indentations in this file? (yaml is white space-sensitive, correct?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill investigate why my system is applying the white space. thats for calling this out

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it linting updates? That's just sort of what it looks like to me. 🤷‍♀️

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah its definitely linting related but not sure why its getting applied now. ill check other yaml files too because those didnt get effected the same maybe?

Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. All of the new links seem to check out 🥳 and all tests pass in both generations locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Ready for review PR ready for review or re-review. Tooling Issue or PR dealing with scripts, workflows, automation, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants