[ENH] Standardise check_y usage via separate _convert_y method #3136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ENH] Standardise
check_yusage via separate_convert_yReference Issues/PRs
What does this implement/fix? Explain your changes.
This PR standardises the usage of
check_yacross base classes to follow the pattern proposed in #2970.Previously, two inconsistent patterns existed:
y = self._check_y(y)self._check_y(y)This caused ambiguity and inconsistent behaviour across different estimator types.
This PR introduces a clear separation of responsibilities by:
_check_y()is used strictly for validation_convert_y()The standard usage is now:
self._check_y(y)y = self._convert_y(y)This pattern is applied consistently to:
This improves clarity, consistency, and prevents unintended side-effects such as overwriting
yor implicit type coercion during validation.Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
No
PR checklist
For all contributions
For new estimators and functions
__maintainer__For developers with write access