AER-4109 Added lower bound to calculation options. #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lower bound value is only put in the map (meaning ends up in the GML) but is not read as it will always use the value related with the type. - Refactored NCA/OWN2000 theme specific Metadata reading/writing to their own classes to keep things cleaner. - Replaced some of the old WNB wording.
BertScholten
requested changes
Nov 13, 2025
source/imaer-gml/src/test/java/nl/overheid/aerius/gml/GMLCalculationSetOptionsReaderTest.java
Show resolved
Hide resolved
...ed/src/main/java/nl/overheid/aerius/shared/domain/calculation/OwN2000CalculationOptions.java
Outdated
Show resolved
Hide resolved
...ed/src/main/java/nl/overheid/aerius/shared/domain/calculation/OwN2000CalculationOptions.java
Outdated
Show resolved
Hide resolved
source/imaer-util/src/main/java/nl/overheid/aerius/util/NcaOptionsMetadataUtil.java
Outdated
Show resolved
Hide resolved
MichielJanssen-DAT
requested changes
Nov 13, 2025
Contributor
MichielJanssen-DAT
left a comment
MichielJanssen-DAT
left a comment
There was a problem hiding this comment.
Some suggestions/questions
source/imaer-gml/src/test/java/nl/overheid/aerius/gml/GMLCalculationSetOptionsReaderTest.java
Outdated
Show resolved
Hide resolved
...ed/src/main/java/nl/overheid/aerius/shared/domain/calculation/OwN2000CalculationOptions.java
Outdated
Show resolved
Hide resolved
source/imaer-util/src/main/java/nl/overheid/aerius/util/NcaOptionsMetadataUtil.java
Outdated
Show resolved
Hide resolved
source/imaer-util/src/main/java/nl/overheid/aerius/util/OptionsMetadataUtil.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower bound value is only put in the map (meaning ends up in the GML) but is not read as it will always use the value related with the type.