Fixes: retry task directly, instead of readd, and guard agains tnull #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Hilbrand
commented
Sep 4, 2025
Hilbrand
commented
- Instead of adding a task back to the scheduler retry it in the loop. This because some other metrics are tracked on tasks, and these are messed up by readding it (unless we would implement some more logic to do an actual re-add to the scheduler. But in that case just do it in the loop makes more sense).
- Added extra null guard for safety.
- Instead of adding a task back to the scheduler retry it in the loop. This because some other metrics are tracked on tasks, and these are messed up by readding it (unless we would implement some more logic to do an actual re-add to the scheduler. But in that case just do it in the loop makes more sense). - Added extra null guard for safety.
SerhatG
reviewed
Sep 4, 2025
source/taskmanager/src/main/java/nl/aerius/taskmanager/TaskDispatcher.java
Show resolved
Hide resolved
SerhatG
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.