Memory leak: do not save objects if no references to cache

[Hartigan]

Hi

I found memory leak inside ReactiveAeroMapper.

java-object-mapper/src/main/java/com/aerospike/mapper/tools/ReactiveAeroMapper.java

Line 218 in 0e422d7

ThreadLocalKeySaver.save(key);

This code allows to save objects into map, but do not increase/decrease reference count, therefore objects permanently stored inside cache. Sync version of mapper has begin() and end() calls for reference counting and doesn't have this problem.

I suggest add verification inside LoadedObjectResolver or add begin() and end() calls into ReactiveAeroMapper

Thanks

[reugn]

@Hartigan, why not call LoadedObjectResolver.begin(); and LoadedObjectResolver.end(); like it's in the blocking read method? In your proposed change, the condition of the if statement never seems to be satisfied.

[Hartigan]

Hi @reugn
I assumed, what LoadedObjectResolver.begin()/end() removed by design from reactive version of mapper. And implementation details of LoadedObjectResolver says what objects not stored if no references to cache created.

[reugn]

@Hartigan, the potential memory leak has been addressed in #165.

[Hartigan]

Yes, its same issue