This repository was archived by the owner on Nov 11, 2019. It is now read-only.
Made localstack work for testing pg-importer #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Java and Kinesis handling; the change to the run_lambda_executor will have to be reverted
…da_executor in a non-crummy way
jrideout
reviewed
Aug 27, 2018
| @@ -1,5 +1,5 @@ | |||
| IMAGE_NAME ?= localstack/localstack | |||
| IMAGE_NAME_BASE ?= localstack/java-maven-node-python | |||
| IMAGE_NAME ?= blafrisch/localstack | |||
There was a problem hiding this comment.
prefer our quay.io repos or if this is meant to be truly public, create an agari/ repo on docker hub.
jonchase
approved these changes
Aug 28, 2018
pparkeragari
approved these changes
Aug 28, 2018
KayoticSully
approved these changes
Aug 29, 2018
KayoticSully
left a comment
KayoticSully
left a comment
There was a problem hiding this comment.
Looks good, hopefully the project will be good about accepting PRs.
This should also effectively "pin" the elasticsearch version too which is something I've wanted to do. If this is going to continue to live on, I would just ask that we pay attention to the ES version anytime we update off of upstream.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.