Skip to content

add typescript definitions #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

add typescript definitions #25

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea9a873
(deps): update package-lock.json
agilgur5 May 29, 2019
ae9fa04
add @types/react by itself - fixup w/ 1st commit to PR
agilgur5 May 29, 2019
f2536de
add typescript definitions
chillitom Nov 5, 2018
060fe9b
fix imports and make extra props optional
chillitom Nov 5, 2018
a2fae62
(format/types): use standard style for types
agilgur5 May 29, 2019
61e4c2f
(types): canvasProps should be more specific than any
agilgur5 May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface IOptions {

// props specific to the React wrapper
export interface SignatureCanvasProps extends IOptions {
canvasProps?: any,
canvasProps?: React.CanvasHTMLAttributes<object>,
Copy link
Owner

@agilgur5 agilgur5 May 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the generic type be <object>?

Copy link
Owner

@agilgur5 agilgur5 Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe leave it as a generic as <T>?: React.CanvasHTMLAttributes<T>? I'm not totally sure why it's a generic or best practices around them in TS

Copy link
Owner

@agilgur5 agilgur5 Aug 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it should be a generic as that's referencing not the object containing the HTML attributes, but the attributes themselves which can be of various types, giving the object various potential shapes

clearOnResize?: boolean
}

Expand Down