forked from blackjk3/react-signature-pad
-
-
Notifications
You must be signed in to change notification settings - Fork 127
add typescript definitions #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ea9a873
(deps): update package-lock.json
agilgur5 ae9fa04
add @types/react by itself - fixup w/ 1st commit to PR
agilgur5 f2536de
add typescript definitions
chillitom 060fe9b
fix imports and make extra props optional
chillitom a2fae62
(format/types): use standard style for types
agilgur5 61e4c2f
(types): canvasProps should be more specific than any
agilgur5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // signature_pad's props | ||
| // (taken from https://github.com/szimek/signature_pad/blob/e2af461bca7ceb7cc5afb8349930908ca19f2f56/src/signature_pad.ts#L23) | ||
| export interface IOptions { | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be |
||
| dotSize?: number | (() => number); | ||
| minWidth?: number; | ||
| maxWidth?: number; | ||
| minDistance?: number; | ||
| backgroundColor?: string; | ||
| penColor?: string; | ||
| throttle?: number; | ||
| velocityFilterWeight?: number; | ||
| onBegin?: (event: MouseEvent | Touch) => void; | ||
| onEnd?: (event: MouseEvent | Touch) => void; | ||
| } | ||
|
|
||
| // props specific to the React wrapper | ||
| export interface SignatureCanvasProps extends IOptions { | ||
| canvasProps: any; | ||
| clearOnResize: boolean; | ||
| } | ||
|
|
||
| export default class SignatureCanvas extends React.Component<SignatureCanvasProps> {} | ||
agilgur5 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we import
signature_pad's types directly fromsignature_pad? I haven't updated to thebetayet (as it's beta) so that might not be possible until then and this might be fine in the meantime