optim: specify version in @babel/plugin-transform-runtime
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the default is 7.0.0, but we are on a newer version, so we can use
newer / more optimized helpers
- `createSuper` now seems to be used, which required 7.9.0:
https://github.com/babel/babel/blob/9199565fa08d840c8f1cc86c1b22be119b538f2f/packages/babel-helpers/src/helpers.ts#L624
- this seems to replace the `possibleConstructorReturn` and
`getPrototypeOf` helpers
- roughly ~6% minified size decrease as a result!
- change babel.config.js's caching to include @babel/runtime's version
since we would need to rebuild if it changes
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Specify a
versionin@babel/plugin-transform-runtime's config to further optimize the output with newer helpers.Details
the default is 7.0.0, but we are on a newer version, so we can use newer / more optimized helpers
createSupernow seems to be used, which required 7.9.0:https://github.com/babel/babel/blob/9199565fa08d840c8f1cc86c1b22be119b538f2f/packages/babel-helpers/src/helpers.ts#L624
possibleConstructorReturnandgetPrototypeOfhelpersroughly ~6% minified size decrease as a result!
change
babel.config.js's caching to include@babel/runtime's version since we would need to rebuild if it changesMisc
Noticed that this was a field when stumbling upon the
@babel/plugin-transform-runtimeoptions in the Babel docs.Tested this simultaneously with #79 as they both affect the output