-
Notifications
You must be signed in to change notification settings - Fork 143
[Snyk] Security upgrade @docusaurus/preset-classic from 3.8.1 to 3.9.0 #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ties The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300775 - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116 - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300777
Summary of ChangesHello @ahochsteger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk aims to upgrade @docusaurus/preset-classic to version 3.9.0 to address several security vulnerabilities. While the intention is good, I've identified two significant issues. First, the PR fails to update other @docusaurus/* packages, leading to version inconsistencies that can cause problems in Docusaurus sites. All @docusaurus packages should be on the same version. Second, and more critically, the PR claims to fix the inflight vulnerability (SNYK-JS-INFLIGHT-6095116), but the resulting package-lock.json still includes a vulnerable version of inflight. This means the primary goal of fixing this vulnerability is not met. I've added specific comments with more details.
| "@docsearch/react": "3.9.0", | ||
| "@docusaurus/core": "3.8.1", | ||
| "@docusaurus/preset-classic": "3.8.1", | ||
| "@docusaurus/preset-classic": "3.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR description states that it fixes the inflight vulnerability (SNYK-JS-INFLIGHT-6095116). However, the package-lock.json in this branch still contains inflight@1.0.6, which is a vulnerable version (the fix is in 1.0.7). This means the vulnerability is not actually remediated by this PR. Please investigate why the dependency was not updated correctly. It might be necessary to update other packages that have inflight as a transitive dependency, or use npm resolutions to force a newer version.
| "@docsearch/react": "3.9.0", | ||
| "@docusaurus/core": "3.8.1", | ||
| "@docusaurus/preset-classic": "3.8.1", | ||
| "@docusaurus/preset-classic": "3.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While updating @docusaurus/preset-classic is correct, it's a strong recommendation for Docusaurus projects to keep all @docusaurus/* packages at the same version to avoid potential conflicts and subtle bugs. This PR leaves other packages like @docusaurus/core at 3.8.1. Please update all @docusaurus/* packages in dependencies and devDependencies to 3.9.0 for consistency. This will also prevent having two different versions of @docusaurus/core in your lockfile.
Snyk has created this PR to fix 3 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
docs/package.jsondocs/package-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-WEBPACKDEVSERVER-10300775
SNYK-JS-INFLIGHT-6095116
SNYK-JS-WEBPACKDEVSERVER-10300777
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.