Fix retry logic to prevent setting exception if future is already done #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the retry logic in the
__retry
method of thesrc/aioice/stun.py
file. The change ensures that theTransactionTimeout
exception is not redundantly set if the future is already completed.src/aioice/stun.py
: Modified the condition in the__retry
method to check if the future (self.__future
) is not already done before setting theTransactionTimeout
exception. This prevents unnecessary operations and potential errors.We experience this case in production here is the stacktrace: