Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ will fallback to a web based map provider (currently Google Maps). Easy to integ
Grab via Gradle:

```groovy
compile 'com.airbnb.android:airmapview:1.8.0'
compile 'com.airbnb.android:airmapview:1.9.1'
```

Snapshots of the development version are available in [Sonatype's `snapshots` repository](https://oss.sonatype.org/content/repositories/snapshots/).
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# org.gradle.parallel=true

VERSION_CODE=16
VERSION_NAME=1.9.0-SNAPSHOT
VERSION_NAME=1.9.1
GROUP=com.airbnb.android

POM_DESCRIPTION=A view abstraction to provide a map user interface with varying underlying map providers.
Expand Down
1 change: 1 addition & 0 deletions library/gradle-maven-push.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ afterEvaluate { project ->
}

task androidJavadocs(type: Javadoc) {
excludes = ['**/*.kt']
source = android.sourceSets.main.java.srcDirs
classpath += project.files(android.getBootClasspath().join(File.pathSeparator))
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -365,11 +365,9 @@ public void setMyLocationButtonEnabled(boolean enabled) {
}
}

@Override public boolean onMapMarkerClick(AirMapMarker<?> airMarker) {
@Override public void onMapMarkerClick(AirMapMarker<?> airMarker) {
if (onMapMarkerClickListener != null) {
return onMapMarkerClickListener.onMapMarkerClick(airMarker);
} else {
return false;
onMapMarkerClickListener.onMapMarkerClick(airMarker);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ public void setOnCameraChangeListener(final OnCameraChangeListener onCameraChang
@Override public boolean onMarkerClick(Marker marker) {
AirMapMarker<?> airMarker = markers.get(marker);
if (airMarker != null) {
return listener.onMapMarkerClick(airMarker);
listener.onMapMarkerClick(airMarker);
}
return false;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,5 @@

public interface OnMapMarkerClickListener {

/*
* Called when an airMarker has been clicked or tapped.
* Return true if the listener has consumed the event (i.e., the default behavior should not occur);
* false otherwise (i.e., the default behavior should occur).
* The default behavior is for the camera to move to the marker and an info window to appear.
* See: https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnMarkerClickListener
* */
boolean onMapMarkerClick(AirMapMarker<?> airMarker);
void onMapMarkerClick(AirMapMarker<?> airMarker);
}
4 changes: 2 additions & 2 deletions sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ android {
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_7
targetCompatibility JavaVersion.VERSION_1_7
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,8 @@ private void appendBitmap(Bitmap bitmap) {
logsRecyclerView.smoothScrollToPosition(adapter.getItemCount() - 1);
}

@Override public boolean onMapMarkerClick(AirMapMarker<?> airMarker) {
@Override public void onMapMarkerClick(AirMapMarker<?> airMarker) {
appendLog("Map onMapMarkerClick triggered with id " + airMarker.getId());
return false;
}

@Override public void onInfoWindowClick(AirMapMarker<?> airMarker) {
Expand Down