Move build directory management from Sh to Elisp #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
reviewed
Dec 18, 2024
vterm.el
Outdated
| (compilation-mode) | ||
| (if (zerop (let ((inhibit-read-only t)) | ||
| (call-process "sh" nil buffer t "-c" make-commands))) | ||
| (call-process "sh" nil t t "-c" make-commands))) |
There was a problem hiding this comment.
You could use create-process-shell-command here.
sirikid
force-pushed
the
vterm-module-compile
branch
from
299acfd to
b286041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved creation of build directory and setting it as current from shell command to Elisp to get rid of masking CMake exit code by
cd. Inspired by #692 but does not fully solve it.I also get rid of unconditional buffer popping, there is not much use in it without build failure.