Initial PR

[HarshNarayanJha]

Initial PR

Closes #2

[ManuelSchneid3r]

Do you think we can find smaller icons? they are really huge.

[HarshNarayanJha]

Do you think we can find smaller icons? they are really huge.

Yeah, we can scale them down.
64x64 will do I guess, since they will be visible in the query items only.

[ManuelSchneid3r]

If there are no svgs available I'd say 128x128. Icons are 40x40 iirc. I.e. hdpi screens need at least 80x80

[HarshNarayanJha]

If there are no svgs available I'd say 128x128. Icons are 40x40 iirc. I.e. hdpi screens need at least 80x80

Indeed, no app icon svgs. I will resize to 128x128 then.

[ManuelSchneid3r]

Another idea, which is even better, is to not ship an icon at all and use "xdg:zed" and "qfip:/Applications/Zed.app" on MacOS. This way icons are theme aware and can't get outdated.

[ManuelSchneid3r]

Sorry for the late response

[ManuelSchneid3r]

Like this https://github.com/albertlauncher/albert-plugin-python-copyq/blob/main/__init__.py#L60-L66

[HarshNarayanJha]

Another idea, which is even better, is to not ship an icon at all and use "xdg:zed" and "qfip:/Applications/Zed.app" on MacOS. This way icons are theme aware and can't get outdated.

Agree, this is much better, but at that time xdg:zed didn't give me correct icon. I will try it.

[HarshNarayanJha]

Sorry my bad, I am using xdg:zed and xdg:zed-preview, and they do work. It's been a long time, that's why I don't remember, I have a toggle to use system icons which uses xdg:zed, which comes from the icon pack (on Linux at least).
By default, it uses the official zed icon, shipped with the plugin, which looks better than ones from the icon themes. I think the jetbrains plugin ships icons too.

I think I will remove the icons entirely, it was my personal preference after all.

What do you think?

[ManuelSchneid3r]

For the shipped official plugin we should respect user preferences. the xdg icon lookup chooses the official icon if no theme icon is available. Users can also overwrite this icon. I don't remember how since I never did, but I remember the icon lookup spec offers this opportunity. You could use this for your personal preference.
If the plugin should work without having the app installed we need a fallback. The icon urls fields is an array for this purpose.

[ManuelSchneid3r]

For jetbrains we should do this as well because they chnage quite often

[HarshNarayanJha]

For the shipped official plugin we should respect user preferences. the xdg icon lookup chooses the official icon if no theme icon is available. Users can also overwrite this icon. I don't remember how as I never did, but I remember the icon lookup spec offers this opportunity. You could use this for your personal preference.

Yeah, I think dropping the icon in ~/.local/share/icons or ~/.icons` should work.

If the plugin should work without having the app installed we need a fallback. The icon urls fields is an array for this purpose.

Got it. But this is not needed for this plugin, since zed needs to be installed.

[HarshNarayanJha]

macOS needs to be tested at this stage.

[HarshNarayanJha]

@ManuelSchneid3r macOS tested. Plugin works as expected. Though users need to "Install CLI" from Zed's menu to have "zed" in path.

Ready to be merged.

[HarshNarayanJha]

I have added a note in the readme.

[HarshNarayanJha]

I have released a new version (bugfix)