-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add IPinfo Lite service #1686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPinfo Lite service #1686
Conversation
Thank you very much! We really appreciate it. We were hoping that someday people would help us bring our Lite DB to a geocoder, but we lack Ruby experts on our team. So, we genuinely appreciate you taking the time and writing the code to bring the Lite API to the project. Thanks! — Abdullah | DevRel, IPinfo |
@abdullahdevrel, you are welcome. Considering the other open PRs, it may take some time for this to receive feedback or even get merged. Is your request about LITE DB related to the "ancient" PR #1324? |
This looks like a great service. And thank you for the clean, easy-to-review PR. Everything looks good except that the methods in |
Thank you for the quick review and the feedback @alexreisner. I fixed the PR and added some general information about the service to a readme file, which I did not spot in the first place. |
Excellent. This looks great. Thanks! |
Oh no. That company is not us. I was referring to this request: #1632 However, instead of the IP to Country ASN database, it should now be the IPinfo Lite Database. We have changed the schema for it. https://ipinfo.io/developers/ipinfo-lite-database The implementation would be similar to MaxMind's MMDB-based implementation because our data also comes in MMDB format. |
Hi there, slightly noddy question – we are using your amazing gem and need to migrate from
We can see that 1.8.5 is from December 18th, 2024, and the commit for Any guidance much appreciated. Many thanks. |
@hemaldev This PR has been merged, but not released yet, with a new gem version. Please feel free to reference this PR in your Gemfile if you want to use IPinfo Lite immediately.
|
And now it's been released! New version was long overdue. Sorry for the delay. |
@alexreisner Thank you, sir! No need to apologise. Thanks for your amazing work. @iltempo Thanks for getting back to me and for providing this solution. After I submitted my comment I did think maybe a possible way forward would be to fork the repo and reference it in my Gemfile, similar to what you are suggesting. But @alexreisner beat us to it! (Out of curiosity, as you have forked this repo, do you plan on keeping your copy on your account or will you delete it now that your work has been merged? This would obviously have impacted us should we have referenced it). |
IPinfo recently added a Lite service that allows unlimited free IP lookups on the country level. This PR adds support for that service.
The results do not contain location information. This is why some tests are skipped.