feat: UI Component Refactoring: ChatMessageList.razor #272 #495
+159
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
requested changes
Oct 12, 2025
| public partial class ChatMessageList : ComponentBase | ||
| { | ||
| [Inject] | ||
| private IJSRuntime JS { get; set; } = default!; |
There was a problem hiding this comment.
- 여기도
public으로 바꿔 주세요. public IJSRuntime? JS { get; set; }으로만 하면 어떤가요?
| { | ||
| if (firstRender) | ||
| { | ||
| await JS.InvokeVoidAsync("import", "./Components/Pages/Chat/ChatMessageList.razor.js"); |
There was a problem hiding this comment.
그러면 여기를 JS!.InvokeVoidAsync(...)로 바꾸면 될 듯?
Comment on lines
+54
to
+58
| // Act - Check initial state before any user interaction | ||
| var chatMessages = Page.Locator("chat-messages"); | ||
| var inProgressAttribute = await chatMessages.GetAttributeAsync("in-progress"); | ||
|
|
||
| // Assert - Initially no InProgressMessage, so attribute should be null |
There was a problem hiding this comment.
여기서 보면 // Act 뒤에, // Assert 뒤에 설명이 붙어 있는데, 이 설명이 없으면 이 테스트 메소드가 설명이 안 되는 건가요? 만약 그렇다면 테스트 메소드 이름에 저 설명을 녹여보면 어떨까요?
Comment on lines
+75
to
+79
| // Verify container structure remains intact | ||
| var containerExists = await messageContainer.IsVisibleAsync(); | ||
| var inputValue = await textArea.InputValueAsync(); | ||
|
|
||
| // Assert - Verify ChatMessageList container is functional and input works |
Comment on lines
+104
to
+121
| // Act - Test the empty state rendering of ChatMessageList | ||
| if (expectedElement == "To get started, try asking about anything.") | ||
| { | ||
| var noMessagesElement = Page.Locator(".no-messages"); | ||
| var isVisible = await noMessagesElement.IsVisibleAsync(); | ||
| var content = await noMessagesElement.InnerTextAsync(); | ||
|
|
||
| // Assert - Verify NoMessagesContent is properly rendered | ||
| isVisible.ShouldBeTrue(); | ||
| content.ShouldContain(expectedElement); | ||
| } | ||
| else if (expectedElement == "User Message Textarea") | ||
| { | ||
| // Test input field exists | ||
| var textArea = Page.GetByRole(AriaRole.Textbox, new() { Name = expectedElement }); | ||
| var inputExists = await textArea.IsVisibleAsync(); | ||
| inputExists.ShouldBeTrue(); | ||
| } |
There was a problem hiding this comment.
전에도 말했지만, 테스트 메소드 안에 if ... else 구문이 있으면 테스트 코드를 잘 못 짠 것입니다. 각각의 조건에 맞춰서 테스트 메소드를 새로 만드세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #272
Purpose
ChatMessageList.razor#272Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
README updated?
The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?
How to Test
What to Check
Verify that the following are valid
Other Information