Connector Implementation & Inheritance: Anthropic Claude #499

qoweh · 2025-10-14T13:52:42Z

Purpose

close Connector Implementation & Inheritance: Anthropic Claude #261

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] New feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

README updated?

The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?

[x] Yes
[ ] No
[ ] N/A

How to Test

Get the code

git clone https://github.com/qoweh/open-chat-playground.git
cd open-chat-playground
git checkout feat/261-ConnectorImplementation-Inheritance-AnthropicClaude

Test the code

dotnet test test/OpenChat.PlaygroundApp.Tests/OpenChat.PlaygroundApp.Tests.csproj --filter FullyQualifiedName~AnthropicConnectorTests

What to Check

Default model and token configuration applied correctly
Exception handling for invalid settings
Inheritance and type casting behavior validation
All related unit tests pass successfully
Docs updated and consistent with Anthropic connector section

Other Information about `AnthropicConnectorTests.cs`

생성/타입 관련

Given_Null_Settings_When_Instantiated_Then_It_Should_Throw()
Given_Settings_When_Instantiated_Then_It_Should_Return()
Given_BaseType_Then_It_Should_Be_AssignableFrom_DerivedType()

EnsureLanguageModelSettingsValid()

Given_Settings_Is_Null_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Throw()
Given_Invalid_ApiKey_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Throw()
Given_Invalid_Model_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Throw()
Given_Valid_Settings_When_EnsureLanguageModelSettingsValid_Invoked_Then_It_Should_Return_True()

GetChatClientAsync()

Given_Valid_Settings_When_GetChatClientAsync_Invoked_Then_It_Should_Return_ChatClient()
Given_Settings_Is_Null_When_GetChatClientAsync_Invoked_Then_It_Should_Throw()
Given_Missing_ApiKey_When_GetChatClientAsync_Invoked_Then_It_Should_Throw()

CreateChatClientAsync()

Given_Valid_Settings_When_CreateChatClientAsync_Invoked_Then_It_Should_Return_ChatClient()
Given_Invalid_Settings_When_CreateChatClientAsync_Invoked_Then_It_Should_Throw()

…-AnthropicClaude

…c Claude integration

…lternative model options

… unit tests

Adds links to the documentation for the Anthropic connector in the README, covering local machine, local container, and Azure deployments. Addresses the need to provide clear instructions for utilizing the new Anthropic connector. Related to aliencube#261

Updates the documentation to refer to Anthropic models instead of the specific Claude model, reflecting the broader range of models now supported. Relates to aliencube#261

…n and ensure proper function invocation

qoweh · 2025-10-14T13:59:56Z

src/OpenChat.PlaygroundApp/Connectors/AnthropicConnector.cs

+        var client = new AnthropicClient() { Auth = new APIAuthentication(apiKey) };
+
+        var chatClient = client.Messages
+                                .AsBuilder()
+                                .UseFunctionInvocation()
+                                .Use((messages, options, next, cancellationToken) =>
+                                {
+                                    options!.ModelId = settings!.Model;
+                                    options.MaxOutputTokens ??= 1000;
+                                    return next(messages, options, cancellationToken);
+                                })
+                                .Build();


테스트 해보다가, anthropic sdk의 api 호출이 잘 안 되어서 우리 프로젝트의 파일들을 살펴봤습니다.

ChatInput.razor.cs 파일에서

private async Task SendMessageAsync() → await OnSend.InvokeAsync(new ChatMessage(ChatRole.User, trimmedText)); 호출

Chat.razor.cs 파일에서

private async Task AddUserMessageAsync(ChatMessage userMessage) → ChatService.GetStreamingResponseAsync([.. messages], chatOptions, currentResponseCancellation.Token) 호출

ChatService.cs 파일에서

public IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseAsync() → return this._chatClient.GetStreamingResponseAsync(chats, options, cancellationToken); 호출

이쪽 부분에서 token 수를 지정해야 호출이 되어서 임의로 토큰수를 1000으로 지정했습니다. 혹시 어떻게 하면 좋을지 궁금합니다.

테스트 해보다가, anthropic sdk의 api 호출이 잘 안 되어서 우리 프로젝트의 파일들을 살펴봤습니다.

호출이 잘 안 됐다는 게 정확히 어떤 의미죠? Exception이 발생했다는 건가요?

앗 네 만약 57번을 주석처리하면
"message":"max_tokens: must be greater than or equal to 1"
이런 식으로 예외가 뜹니다

fail: Microsoft.AspNetCore.Components.Server.Circuits.CircuitHost[111]
Unhandled exception in circuit 'F9Rlr3x3VTCcGA5lnf-m5VlCqoos2nCX63LAzBhR2Ow'.
System.Net.Http.HttpRequestException: {"type":"error","error":{"type":"invalid_request_error","message":"max_tokens: must be greater than or equal to 1"},"request_id":"req_011CU7LZEatnHLLUn6kkH2h7"}
at Anthropic.SDK.BaseEndpoint.HttpRequestRaw(String url, HttpMethod verb, Object postData, Boolean streaming, CancellationToken ctx)
at Anthropic.SDK.EndpointBase.HttpStreamingRequestMessages(String url, HttpMethod verb, Object postData, CancellationToken ctx)+MoveNext()
at Anthropic.SDK.EndpointBase.HttpStreamingRequestMessages(String url, HttpMethod verb, Object postData, CancellationToken ctx)+System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult()

MaxToken 값이 필수인 것으로 보이는데, appsettings.json 부터 차근차근 추가할 필요가 있어 보이는데요?

MaxToken 값이 필수인 것으로 보이는데, appsettings.json 부터 차근차근 추가할 필요가 있어 보이는데요?

@sikutisa 아하.. 그러면 필요한 부분 살펴보고 정리해서 말씀드리겠습니다!

justinyoo · 2025-10-16T00:39:15Z

@qoweh #494 PR이 머지가 됐으므로 테스트 코드는 이를 참고해서 작성해 주세욥! 촘촘하게 작성하셔야 합니다.

…-AnthropicClaude

Related to : aliencube#342 * Add `MaxTokens` parameter to the Anthropic section in appsettings.json (Microsoft.Extensions.Configuration.Binder automatically converts string values to integers when binding configuration)

Relate to : aliencube#258 * Add`MaxTokens` property to AnthropicSettings

…lementation-Inheritance-AnthropicClaude

* update LanguageModelConnector to include Anthropic in unsupported list * will be re-enabled when Anthropic PR is merged

* mark all AnthropicConnectorTests as skipped to avoid CI failures while connector is unsupported

qoweh · 2025-10-16T18:07:32Z

src/OpenChat.PlaygroundApp/Configurations/AnthropicSettings.cs

 {
    /// <summary>
-    /// Gets or sets the API key for Anthropic Claude.
+    /// Gets or sets the API key for Anthropic.


20번, 25번, 30번 라인에서 Calude를 뺏다가 다시 넣었는데요, (20번줄은 다시 안 넣었네요)
Anthropic Claude 라고 하는 것보다 Anthropic으로 넣는 게 맞는 것 같은데 어떤 식으로 할까요?

…hropic settings

…-AnthropicClaude

qoweh added 21 commits September 13, 2025 16:07

refactor: split UI logic in ChatHeader.razor

4714dd8

test: add integration tests for NewChat button and icon visibility

04735cc

Merge remote-tracking branch 'upstream/main'

a8f0a7d

Merge remote-tracking branch 'origin/main'

6e68171

Merge branch 'aliencube:main' into main

1f5783c

Merge branch 'aliencube:main' into main

5094a9f

Merge branch 'aliencube:main' into main

8ed4bfd

Merge branch 'aliencube:main' into main

39354bc

Merge branch 'aliencube:main' into main

cf64868

Merge branch 'aliencube:main' into main

6cfef60

Merge branch 'aliencube:main' into main

aeb63e8

Merge branch 'main' into feat/261-ConnectorImplementation-Inheritance…

1e225a0

…-AnthropicClaude

feat: Add support for Anthropic API integration and update documentation

bb8dcbf

feat: Add documentation for running OpenChat Playground with Anthropi…

ebf7b2b

…c Claude integration

feat: Update default model references to Claude Sonnet 4 and adjust a…

e06184b

…lternative model options

feat: Add support for Anthropic connector in LanguageModelConnector

e3dba70

feat: Implement Anthropic connector for LanguageModel integration

15881b4

feat: Enhance AnthropicConnector with improved error handling and add…

0708685

… unit tests

Updates documentation to refer to Anthropic models

c625f11

Updates the documentation to refer to Anthropic models instead of the specific Claude model, reflecting the broader range of models now supported. Relates to aliencube#261

feat: Refactor GetChatClientAsync to improve API client initializatio…

9bc001b

…n and ensure proper function invocation

qoweh commented Oct 14, 2025

View reviewed changes

sikutisa assigned qoweh Oct 14, 2025

sikutisa added ossca p1 team-kim phase-1 task vendor labels Oct 14, 2025

qoweh added 7 commits October 16, 2025 10:41

Merge branch 'aliencube:main' into main

4842bc8

Merge branch 'main' into feat/261-ConnectorImplementation-Inheritance…

24c3dd5

…-AnthropicClaude

feat: add max_tokens parameter for Anthropic in appsettings.json

d23c92b

Related to : aliencube#342 * Add `MaxTokens` parameter to the Anthropic section in appsettings.json (Microsoft.Extensions.Configuration.Binder automatically converts string values to integers when binding configuration)

feat: add property MaxTokens for Anthropic in AnthropicSettings

92c3eed

Relate to : aliencube#258 * Add`MaxTokens` property to AnthropicSettings

Merge remote-tracking branch 'origin/main' into feat/261-ConnectorImp…

604dcf3

…lementation-Inheritance-AnthropicClaude

fix: temporarily disable Anthropic

1a58fb7

* update LanguageModelConnector to include Anthropic in unsupported list * will be re-enabled when Anthropic PR is merged

test: skip all Anthropic connector tests until enabled

9c51809

* mark all AnthropicConnectorTests as skipped to avoid CI failures while connector is unsupported

qoweh commented Oct 16, 2025

View reviewed changes

qoweh added 2 commits October 19, 2025 02:02

refactor: update documentation to remove "Claude" references from Ant…

06efab1

…hropic settings

Merge branch 'main' into feat/261-ConnectorImplementation-Inheritance…

99b7de9

…-AnthropicClaude

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Connector Implementation & Inheritance: Anthropic Claude #499

Connector Implementation & Inheritance: Anthropic Claude #499

qoweh commented Oct 14, 2025

Uh oh!

qoweh Oct 14, 2025 •

edited

Loading

Uh oh!

sikutisa Oct 14, 2025

Uh oh!

qoweh Oct 14, 2025 •

edited

Loading

Uh oh!

sikutisa Oct 14, 2025

Uh oh!

qoweh Oct 14, 2025

Uh oh!

justinyoo commented Oct 16, 2025

Uh oh!

qoweh Oct 16, 2025

Uh oh!

justinyoo Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Connector Implementation & Inheritance: Anthropic Claude #499

Are you sure you want to change the base?

Connector Implementation & Inheritance: Anthropic Claude #499

Conversation

qoweh commented Oct 14, 2025

Purpose

Does this introduce a breaking change?

Pull Request Type

README updated?

How to Test

What to Check

Other Information about AnthropicConnectorTests.cs

생성/타입 관련

EnsureLanguageModelSettingsValid()

GetChatClientAsync()

CreateChatClientAsync()

Uh oh!

qoweh Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sikutisa Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

qoweh Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sikutisa Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

qoweh Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

justinyoo commented Oct 16, 2025

Uh oh!

qoweh Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

justinyoo Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Other Information about `AnthropicConnectorTests.cs`

qoweh Oct 14, 2025 •

edited

Loading

qoweh Oct 14, 2025 •

edited

Loading