Skip to content

Conversation

@IamGroooooot
Copy link
Contributor

Purpose

Docker Model Runner 관한 command line option을 파싱할 수 있게 구현하고 관련 테스트를 추가했습니다.

Closes: #277
Supersedes: #471

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] New feature  
[ ] Bugfix  
[ ] Refactoring (no functional changes, no api changes)  
[ ] Documentation content changes  
[ ] Other... Please describe:

README updated?

The top-level readme for this repo contains a link to each sample in the repo. If you're adding a new sample did you update the readme?

[ ] Yes
[ ] No
[x] N/A

How to Test

  • Get the code

  • Test the code

     # ArgumentOptionsTests에서 DMR 관련 데이터행(InlineData)만 실행
     $ dotnet test test/OpenChat.PlaygroundApp.Tests/OpenChat.PlaygroundApp.Tests.csproj --filter "FullyQualifiedName~OpenChat.PlaygroundApp.Tests.Options.DockerModelRunnerArgumentOptionsTests"
     
     # 인자값에 “DockerModelRunner”가 들어간 케이스만 테스트
     $ dotnet test test/OpenChat.PlaygroundApp.Tests/OpenChat.PlaygroundApp.Tests.csproj --filter "FullyQualifiedName~OpenChat.PlaygroundApp.Tests.Abstractions.ArgumentOptionsTests&DisplayName~DockerModelRunner"

    The test should pass.
    image

What to Check

  • Docker Model Runner의 인자를 파싱할 때 config-only, CLI-only, 혼합 입력 모두 정상 동작하는지 확인
  • --help 옵션에 Docker Model Runner 관련 인자가 출력되는지 확인

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 좋습니다!

@justinyoo justinyoo merged commit 0a28cf7 into aliencube:main Oct 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command-Line Argument Parsing: Docker Model Runner

2 participants