Make gobject-introspection actually optional #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the readme it says that gobject-introspection is optional, however without this change the configure would fail with `HAVE_INTROSPECTION does not appear in AM_CONDITIONAL` after this change, configuring without gobject-introspection works as it should tested by changing the source of the nixpkgs i3ipc-glib drv to point to my local checkout with this change applied verified that `share/gir-1.0/i3ipc-1.0.gir-1` exists copied from https://github.com/harfbuzz/harfbuzz/blob/63bc6be0cf7151dfbd7a004f5b644e802c2ff6ca/configure.ac#L173-L186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the readme it says that gobject-introspection is optional, however
without this change the configure would fail with
HAVE_INTROSPECTION does not appear in AM_CONDITIONALafter this change, configuring without gobject-introspection works as it
should
tested by changing the source of the nixpkgs i3ipc-glib drv to point to
my local checkout with this change applied
verified that
share/gir-1.0/i3ipc-1.0.gir-1existscopied from https://github.com/harfbuzz/harfbuzz/blob/63bc6be0cf7151dfbd7a004f5b644e802c2ff6ca/configure.ac#L173-L186
would close #36 and #31 if they were open