Add cunit test for libutempter #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgzones
reviewed
Mar 18, 2022
libutempter/Makefile
Outdated
| PROJECT = utempter | ||
| VERSION = $(shell sed '/^Version: */!d;s///;q' libutempter.spec) | ||
| MAJOR = 0 | ||
| RMFLAGS = -fr |
Contributor
There was a problem hiding this comment.
Why the recursive flag? I see no directories removed.
Author
There was a problem hiding this comment.
In the development process, I have directories store line coverage data, but I forgot to remove -r flag. Now I remove them
libutempter/Makefile
Outdated
| VERSION = $(shell sed '/^Version: */!d;s///;q' libutempter.spec) | ||
| MAJOR = 0 | ||
| RMFLAGS = -fr | ||
| CC = gcc |
Contributor
There was a problem hiding this comment.
Why fix the compiler to GCC? Clang is also supported and for cross-compiling CC must be override-able.
Author
There was a problem hiding this comment.
Thanks for your advice, now I stop overriding CC flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cunit test for libutempter to test libutempter interface.