Skip to content

support early returns and typeof checks for feature detection #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bschlenk wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

support early returns and typeof checks for feature detection #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d43f0fa
fix snapshot - why?
bschlenk Sep 22, 2023
657e20b
cleanup, version cannot be number
bschlenk Sep 22, 2023
9163c99
update snapshot with reversed results
bschlenk Sep 22, 2023
e8f8fc6
clean up unnecessary types
bschlenk Sep 22, 2023
722edeb
move to non-inline snapshot
bschlenk Sep 22, 2023
6a50593
use this in getUnsupportedTargets
bschlenk Sep 22, 2023
f8774d0
use eslint types instead of defining own
bschlenk Sep 24, 2023
7e2b0d6
settings cannot be null
bschlenk Sep 25, 2023
d969684
move settings determination to helper
bschlenk Sep 25, 2023
24e6fa9
replace deprecated context methods
bschlenk Sep 25, 2023
4c8fa11
WIP
bschlenk Sep 25, 2023
ce1c17f
a few more changes
bschlenk Oct 13, 2023
965f3f7
all tests pass
bschlenk Oct 15, 2023
53d81ba
clean up and fix tests
bschlenk Oct 15, 2023
d309a3c
add more tests and fixes
bschlenk Oct 15, 2023
501a211
collect coverage, add tests, refactor
bschlenk Oct 15, 2023
419f1fe
small optimization early return
bschlenk Oct 15, 2023
07ab02e
remove unused AstNodeType
bschlenk Oct 15, 2023
152092d
hack in support for lookbehind regex check
bschlenk Oct 15, 2023
cd68892
bump caniuselite
bschlenk Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"lint": "eslint --ignore-path .gitignore --ext .js,.ts .",
"spec": "jest --testPathIgnorePatterns test/e2e-repo.spec.ts /benchmarks-tmp",
"spec:e2e": "jest test/e2e-repo.spec.ts",
"spec:watch": "npm run spec -- --watch",
"test": "npm run lint && npm run build && npm run spec",
"tsc": "tsc",
"version": "npm run build"
Expand All @@ -61,7 +62,13 @@
],
"rules": {
"import/extensions": "off",
"import/no-extraneous-dependencies": "off"
"import/no-extraneous-dependencies": "off",
"@typescript-eslint/no-use-before-define": [
"error",
{
"functions": false
}
]
},
"root": true
},
Expand All @@ -70,13 +77,14 @@
"testEnvironment": "node",
"testPathIgnorePatterns": [
"/benchmarks-tmp/"
]
],
"collectCoverage": true
},
"dependencies": {
"@mdn/browser-compat-data": "^5.3.16",
"ast-metadata-inferer": "^0.8.0",
"browserslist": "^4.21.10",
"caniuse-lite": "^1.0.30001534",
"caniuse-lite": "^1.0.30001549",
"find-up": "^5.0.0",
"lodash.memoize": "^4.1.2",
"semver": "^7.5.4"
Expand Down
35 changes: 3 additions & 32 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,6 @@
export interface TargetNameMappings {
chrome: "Chrome";
firefox: "Firefox";
safari: "Safari";
ios_saf: "iOS Safari";
ie: "IE";
ie_mob: "IE Mobile";
edge: "Edge";
baidu: "Baidu";
electron: "Electron";
blackberry_browser: "Blackberry Browser";
edge_mobile: "Edge Mobile";
and_uc: "Android UC Browser";
and_chrome: "Android Chrome";
and_firefox: "Android Firefox";
and_webview: "Android Webview";
and_samsung: "Samsung Browser";
and_opera: "Opera Android";
opera: "Opera";
opera_mini: "Opera Mini";
opera_mobile: "Opera Mobile";
node: "Node.js";
kaios: "KaiOS";
}

// Maps an ID to the full name user will see
// E.g. during error, user will see full name instead of ID
export const STANDARD_TARGET_NAME_MAPPING: Readonly<TargetNameMappings> = {
export const STANDARD_TARGET_NAME_MAPPING = {
chrome: "Chrome",
firefox: "Firefox",
safari: "Safari",
Expand All @@ -48,10 +23,6 @@ export const STANDARD_TARGET_NAME_MAPPING: Readonly<TargetNameMappings> = {
opera_mobile: "Opera Mobile",
node: "Node.js",
kaios: "KaiOS",
};
} as const;

export enum AstNodeTypes {
MemberExpression = "MemberExpression",
CallExpression = "CallExpression",
NewExpression = "NewExpression",
}
export type TargetNameMappings = typeof STANDARD_TARGET_NAME_MAPPING;
Loading