Adding slots for empty filter results and empty dataset provided #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node's text & id are flat and we can search node's id as regex too
style for RTL direction
filter node with id
Switching from mustache to v-html option allows to output both text and HTML message on filter "nothing found"
Modify emptyText output
Add draggable class to TreeNode
Rethinking my previous PR: it is better to have wonderful component slot to display message on empty filtering result. We can get rid of emptyText prop and custom div with custom class. And along with this: it is good to have slot for empty dataset message. Because when we fetch data from external source - we never know if there is actually any structure. So I added another slot on matches.length == 0
Adding slotted messages in TreeRoot.vue
Revert "Adding slotted messages in TreeRoot.vue"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested! Hopefully it will be ok this time)