Skip to content

Conversation

LBFFilho
Copy link
Contributor

@LBFFilho LBFFilho commented Oct 10, 2025

Quartus requires that all blocks inside generate statements have a label. The lack of these block labels was causing some projects to fail to build.

https://www.intel.com/content/www/us/en/support/programmable/articles/000090348.html

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)
  • Documentation

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Add missing block names to loops in pack_shell.v

Signed-off-by: Laez Barbosa <laez.barbosa@analog.com>
@LBFFilho
Copy link
Contributor Author

RetriggerCI

Copy link
Contributor

@IstvanZsSzekely IstvanZsSzekely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the license header.

@LBFFilho
Copy link
Contributor Author

The header is already up to date (it had already been modified this year)

@IstvanZsSzekely
Copy link
Contributor

The header is already up to date (it had already been modified this year)

The year structure might not be supported by the checker. Thanks for pointing that out! (I only looked at the error message)

@LBFFilho LBFFilho merged commit 130abf7 into main Oct 16, 2025
2 of 4 checks passed
@LBFFilho LBFFilho deleted the pack_shell_fix branch October 16, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants