add MAX17616/MAX17616A driver #2949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseerp
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa and
rbolboac
as code owners
kseerp
force-pushed
the
dev-max17616
branch
from
c3062cc to
4b58025
Compare
nunojsa
reviewed
Sep 23, 2025
Documentation/devicetree/bindings/hwmon/pmbus/adi,max17616.yaml
Outdated
Show resolved
Hide resolved
|
Series applied upstream, add ADI compliant version. |
|
Follow up patch and updates added |
gastmaier
reviewed
Oct 16, 2025
gastmaier
reviewed
Oct 16, 2025
Comment on lines
52
to
59
| in1_label "vin" | ||
| in1_input Measured input voltage | ||
| in1_alarm Input voltage alarm | ||
| in2_label "vout1" | ||
| in2_input Measured output voltage | ||
| curr1_label "iout1" | ||
| curr1_input Measured output current. | ||
| curr1_alarm Output current alarm | ||
| temp1_input Measured temperature | ||
| temp1_alarm Chip temperature alarm |
There was a problem hiding this comment.
Are you mixing tabs and spaces here?
Consider just using spaces
gastmaier
reviewed
Oct 16, 2025
Comment on lines
+8
to
+14
| * Analog Devices MAX17616/MAX17616A | ||
|
|
||
| Prefix: 'max17616' | ||
|
|
||
| Addresses scanned: - | ||
|
|
||
| Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/max17616-max17616a.pdf |
There was a problem hiding this comment.
Suggested change
| * Analog Devices MAX17616/MAX17616A | |
| Prefix: 'max17616' | |
| Addresses scanned: - | |
| Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/max17616-max17616a.pdf | |
| - | Analog Devices MAX17616/MAX17616A | |
| | Prefix: 'max17616' | |
| | Addresses scanned: - | |
| | Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/max17616-max17616a.pdf |
You can force linebreaks using this syntax
gastmaier
reviewed
Oct 16, 2025
Documentation/hwmon/max17616.rst
Outdated
|
|
||
| Author: | ||
|
|
||
| - Kim Seer Paller <kimseer.paller@analog.com> |
There was a problem hiding this comment.
leading whitespace has a meaning in rst, it will nest the list in a block.
It is not a big deal, but does have an effect.
| ----------- | ||
|
|
||
| This driver does not auto-detect devices. You will have to instantiate | ||
| the devices explicitly. Please see Documentation/i2c/instantiating-devices.rst |
There was a problem hiding this comment.
Suggested change
| the devices explicitly. Please see Documentation/i2c/instantiating-devices.rst | |
| the devices explicitly. Please see :doc:`/i2c/instantiating-devices` |
https://www.sphinx-doc.org/en/master/usage/referencing.html#role-doc
There was a problem hiding this comment.
Note these are patches already applied upstream. So any change needs to go first there
There was a problem hiding this comment.
I used existing driver's rst as template. Should I update to consistent spacing/syntax or keep the current format for consistency with other docs?
Add device tree documentation for MAX17616/MAX17616A current-limiter with overvoltage/surge, undervoltage, reverse polarity, loss of ground protection with PMBus interface. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20250930-upstream-max17616-v1-1-1525a85f126c@analog.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Add interrupt property to document the SMBALERT pin functionality for fault condition signal. Suggested-by: Marcelo Schmitt <marcelo.schmitt@analog.com> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> Link: https://lore.kernel.org/r/20251013-upstream-max17616-v1-1-0e15002479c3@analog.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Add support for MAX17616/MAX17616A current-limiter with overvoltage/surge, undervoltage, reverse polarity, loss of ground protection with PMBus interface. The PMBus interface allows monitoring of input/output voltages, output current and temperature. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com> Link: https://lore.kernel.org/r/20250930-upstream-max17616-v1-2-1525a85f126c@analog.com [groeck: Fixed htmldocs 'WARNING: Title underline too short' as reported by Kriish Sharma <kriish.sharma2006@gmail.com>] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Add MAX17616 to the ADI Kconfig. Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
|
changelog:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add MAX17616/MAX17616A Current-Limiter with Overvoltage/Surge, Undervoltage, Reverse Polarity, Loss of Ground Protection with PMBus Interface
Lore: https://patchew.org/linux/20250930-upstream-max17616-v1-0-1525a85f126c@analog.com/
PR Type
PR Checklist