Small adrv9002 improvements #2976
Merged
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested review from
amiclaus,
btogorean,
buha,
chegbeli,
dbogdan,
mhennerich and
rbolboac
as code owners
There's no reason for that buffer to not be const. Furthermore jsmn_parse() indeed expects a const buffer. Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Given that adi_adrv9001_profileutil_Parse() now accepts a const buffer and that the bounce buffer was mainly to avoid hacky casts from const to non const buffers, simplify adrv9002_profile_load() by directly passing the fw->data to adi_adrv9001_profileutil_Parse(). Signed-off-by: Nuno Sá <nuno.sa@analog.com>
ADRV9002_PORT_MASK() already takes care between RX vs TX differences when dealing with port masks. Hence the if() else is useless and in fact the statements in each branch are the same. Caught by coccinelle (through CI). Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Use __free(firmware) in order to automatically release the requested firmware and simplify code paths. Note that adrv9002_init_cals_handle() we do not use as that functions makes use of goto jumps which does not properly work with the cleanup stuff (see cleanup.h for more details). Signed-off-by: Nuno Sá <nuno.sa@analog.com>
nunojsa
changed the title
nunojsa
force-pushed
the
staging/xlnx/adrv9002-improvements
branch
from
814f894 to
ae5d019
Compare
gastmaier
reviewed
Oct 27, 2025
There was a problem hiding this comment.
- iio: adc: adrv9002: profileutil: Constify jsonbuffer
OK, Constify is just a weird word - iio: adc: adrv9002: Drop profile bounce buffer
OK - iio: adc: adrv9002: Drop useless if() condition
OK, yes, the lines in the if are identical, probably older than the macron itself. - iio: adc: adrv9002: Use firmware auto cleanup
OK, makes things simpler
| unsigned long *prate) | ||
| { | ||
| struct adrv9002_clock *clk_priv = to_clk_priv(hw); | ||
|
|
There was a problem hiding this comment.
I think the deadcode for dev_dbg occurs for if the DEBUG symbols are missing and the method is optimized away.
Adding to the todo-list to see if really the case, and enable in adi_ci_defconfig if so.
The already enabled flags are
CONFIG_MODULE_DEBUG=y
CONFIG_DEBUG_DRIVER=y
CONFIG_DEBUG_KERNEL=y
CONFIG_DEBUG_FS=y
There was a problem hiding this comment.
Yeah, most likely. I'll actually evaluate to drop those dev_dbg(). Not that useful anyways
| else | ||
| profile = phy->chip->lvd_profile; | ||
|
|
||
| const struct firmware *fw __free(firmware) = NULL; |
| #define ADI_ADRV9001_TOKEN_MAX_LENGTH 32 | ||
|
|
||
| int32_t adi_adrv9001_profileutil_Parse(adi_adrv9001_Device_t *device, adi_adrv9001_Init_t *init, char * jsonBuffer, uint32_t length) | ||
| int32_t adi_adrv9001_profileutil_Parse(adi_adrv9001_Device_t *device, adi_adrv9001_Init_t *init, const char * jsonBuffer, uint32_t length) |
There was a problem hiding this comment.
Since already fixing trailing whitespace, could fix the space between the pointer operator and the var name
Suggested change
| int32_t adi_adrv9001_profileutil_Parse(adi_adrv9001_Device_t *device, adi_adrv9001_Init_t *init, const char * jsonBuffer, uint32_t length) | |
| int32_t adi_adrv9001_profileutil_Parse(adi_adrv9001_Device_t *device, adi_adrv9001_Init_t *init, const char *jsonBuffer, uint32_t length) |
There was a problem hiding this comment.
This is API stuff and all the white spaces will be lost anyways (since when I send the PR to the BU I only take the real change into account). The whites spaces in here is because I have my editor to automatically trim them on save and I'm lazy to care about it 😅
gastmaier
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Minor code simplifications for the adrv9002 driver.
PR Type
PR Checklist