Skip to content

feat: add testIDs for android with automation supports #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add testIDs for android with automation supports #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/OtpInput/OtpInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props, ref) => {
theme = {},
textInputProps,
textProps,
buttonProps,
type = "numeric",
} = props;
const {
Expand Down Expand Up @@ -82,7 +83,13 @@ export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props, ref) => {
disabled={disabled}
onPress={handlePress}
style={generatePinCodeContainerStyle(isFocusedContainer, char)}
testID="otp-input"
{...buttonProps}
testID={buttonProps?.testID ? `${buttonProps.testID}${index}` : `otp-input-${index}`}
{...(Platform.OS === "android" && {
accessibilityLabel: buttonProps?.testID
? `${buttonProps.testID}${index}`
: `otp-input-${index}`,
})}
>
{isFocusedInput && !hideStick ? (
<VerticalStick
Expand All @@ -93,7 +100,12 @@ export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props, ref) => {
) : (
<Text
{...textProps}
testID={textProps?.testID ? `${textProps.testID}-${index}` : undefined}
testID={textProps?.testID ? `${textProps.testID}${index}` : undefined}
{...(Platform.OS === "android" && {
accessibilityLabel: textProps?.testID
? `${textProps.testID}${index}`
: `otp-input-text-${index}`,
})}
style={[
styles.codeText,
pinCodeTextStyle,
Expand All @@ -120,6 +132,7 @@ export const OtpInput = forwardRef<OtpInputRef, OtpInputProps>((props, ref) => {
aria-disabled={disabled}
editable={!disabled}
testID="otp-input-hidden"
{...(Platform.OS === "android" && { accessibilityLabel: "otp-input-hidden" })}
onFocus={handleFocus}
onBlur={handleBlur}
caretHidden={Platform.OS === "ios"}
Expand Down
10 changes: 9 additions & 1 deletion src/OtpInput/OtpInput.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { ColorValue, TextInputProps, TextProps, TextStyle, ViewStyle } from "react-native";
import {
ColorValue,
TextInputProps,
TextProps,
TextStyle,
ViewStyle,
PressableProps,
} from "react-native";

export interface OtpInputProps {
numberOfDigits?: number;
Expand All @@ -16,6 +23,7 @@ export interface OtpInputProps {
disabled?: boolean;
textInputProps?: TextInputProps;
textProps?: TextProps;
buttonProps?: PressableProps;
type?: "alpha" | "numeric" | "alphanumeric";
placeholder?: string;
}
Expand Down
5 changes: 4 additions & 1 deletion src/OtpInput/VerticalStick.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as React from "react";
import { memo, useEffect, useRef } from "react";
import { Animated, ColorValue, View, ViewStyle } from "react-native";
import { Animated, ColorValue, View, ViewStyle, Platform } from "react-native";
import { styles } from "./OtpInput.styles";

interface VerticalStickProps {
Expand Down Expand Up @@ -38,6 +38,9 @@ export const VerticalStick: React.FC<VerticalStickProps> = memo(
<View
style={[styles.stick, focusColor ? { backgroundColor: focusColor } : {}, style]}
testID="otp-input-stick"
{...(Platform.OS === "android" && {
accessibilityLabel: "otp-input-stick",
})}
/>
</Animated.View>
);
Expand Down