Catch Error when dumping thread states in IdlingPolicy.
#2441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_802617162
branch
from
3ffc559 to
305eb48
Compare
Expand the catch block to include `Error` types in addition to `RuntimeException` when calling `TestOutputEmitter.dumpThreadStates`. This ensures that any issues during thread state dumping are suppressed and added to the `AppNotIdleException`, preserving the original exception as the primary cause. `java.lang.ExceptionInInitializerError` can happen when static initializing `TestOutputEmitter` if more than one service is discovered. PiperOrigin-RevId: 802644040
copybara-service
bot
force-pushed
the
piper_802617162
branch
from
305eb48 to
5d68f50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch
Errorwhen dumping thread states inIdlingPolicy.Expand the catch block to include
Errortypes in addition toRuntimeExceptionwhen callingTestOutputEmitter.dumpThreadStates. This ensures that any issues during thread state dumping are suppressed and added to theAppNotIdleException, preserving the original exception as the primary cause.java.lang.ExceptionInInitializerErrorcan happen when static initializingTestOutputEmitterif more than one service is discovered.