Made the changes to Remove the PiP #396
Conversation
Summary of ChangesHello @praneethatchana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically removes all Picture-in-Picture (PiP) functionality from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully removes the Picture-in-Picture (PiP) implementation by updating the Android Manifest and removing the corresponding code from the activities. The changes are generally good and align with the PR's objective. However, a critical aspect has been overlooked: the automated tests related to PiP functionality in PiPMovieActivityTest.kt and PiPSampleActivityTest.kt have not been updated. These tests will now fail or are obsolete, and should be removed or modified to reflect the code changes. I have also left one minor comment regarding code clarity.
| */ | ||
| private fun minimize() { | ||
| enterPictureInPictureMode(updatePictureInPictureParams()) | ||
| // Used for Entering to Picture-in-Picture mode. |
There was a problem hiding this comment.
This comment is unhelpful and contains a grammatical error. Since the function is now a no-op to disable Picture-in-Picture, an empty body is self-explanatory. It's best to remove this comment. Additionally, the KDoc for the minimize function is now misleading and should be updated to reflect that PiP is disabled.
There was a problem hiding this comment.
As per Gemini comment, please remove comment as it's not applicable with that code removal.
| android:configChanges="screenSize|smallestScreenSize|screenLayout|orientation" | ||
| android:exported="true" | ||
| android:supportsPictureInPicture="true" | ||
| android:supportsPictureInPicture="false" |
There was a problem hiding this comment.
Can we just remove the attribute/line altogether rather than setting it to false.
| */ | ||
| private fun minimize() { | ||
| enterPictureInPictureMode(updatePictureInPictureParams()) | ||
| // Used for Entering to Picture-in-Picture mode. |
There was a problem hiding this comment.
As per Gemini comment, please remove comment as it's not applicable with that code removal.
|
@praneethatchana let's remove the pip test in PiPSampleActivityTest.kt so the build checks pass. Thanks |
ashnohe
left a comment
ashnohe
left a comment
There was a problem hiding this comment.
LGTM after Aaron's suggestions implemented
3 participants
Made the changes to Remove the PiP implementation and also Removed the Unused Code.