Skip to content

refactor(aria/grid): rework cell widget and wrap continuous behavior #32290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

refactor(aria/grid): rework cell widget and wrap continuous behavior #32290

merged 3 commits into from
Nov 13, 2025

Conversation

@ok7sai
Copy link
Member

@ok7sai ok7sai commented Nov 10, 2025 •
edited
Loading

Added grid table example and improved grid calendar example.

@ok7sai ok7sai added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025 •
edited
Loading

Deployed dev-app for 3c00f96 to: https://ng-dev-previews-comp--pr-angular-components-32290-dev-ae8kdl6n.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@ok7sai ok7sai force-pushed the ng-aria-grid branch 7 times, most recently from 2cc7dcf to 61d1587 Compare November 11, 2025 19:32
@ok7sai ok7sai changed the title refactor(aria/grid): rework cell widget refactor(aria/grid): rework cell widget and wrap continuous behavior Nov 11, 2025
@ok7sai ok7sai requested a review from wagnermaciel November 11, 2025 19:33
@ok7sai ok7sai marked this pull request as ready for review November 11, 2025 19:33
@ok7sai ok7sai requested a review from a team as a code owner November 11, 2025 19:33
@ok7sai ok7sai requested review from adolgachev and removed request for a team November 11, 2025 19:33
@ok7sai ok7sai force-pushed the ng-aria-grid branch 2 times, most recently from 6949820 to ff6f7e5 Compare November 11, 2025 20:32
@ok7sai ok7sai marked this pull request as draft November 11, 2025 20:33
@ok7sai ok7sai marked this pull request as ready for review November 11, 2025 20:44
@ok7sai ok7sai requested a review from wagnermaciel November 11, 2025 20:44
wagnermaciel
wagnermaciel reviewed Nov 12, 2025
View reviewed changes
src/components-examples/aria/grid/grid-table/grid-table-example.html
Comment on lines 33 to 41
<div
role="button"
ngGridCellWidget
widgetType="editable"
(onActivate)="startEdit($event, task, summaryInput)"
(onDeactivate)="completeEdit($event, task)"
(click)="widget.activate()"
#widget="ngGridCellWidget"
>
Copy link
Contributor

@wagnermaciel wagnermaciel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for having the user call widget.activate() on click instead of this being handled internally?

Copy link
Member Author

@ok7sai ok7sai Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add that because I've seen some data table design (like Google Sheets) requires double click to enter the edit mode, and I also don't know if clicking on an input box should activate the widget, or wait until user typing. in fact I was event tempting to use (dblclick) event here instead of (click) for something that's editable.

src/aria/private/grid/grid.ts
}

/** Resets the active state of the grid if it is empty or stale. */
resetStateEffect(): void {
Copy link
Contributor

@wagnermaciel wagnermaciel Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we are doing a lot of special casing to handle deletions or reordering. I am wondering if there is an alternative approach we can consider that handles these cases more gracefully

One thing to consider is whether shifting some of the state-fixing responsibility to the developer would remove a lot of these special checks we are doing

@ok7sai ok7sai force-pushed the ng-aria-grid branch 2 times, most recently from 6135239 to 626dce8 Compare November 12, 2025 10:35
@ok7sai ok7sai requested a review from wagnermaciel November 12, 2025 10:37
@ok7sai ok7sai added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate labels Nov 13, 2025
@ok7sai ok7sai merged commit 3d74ca6 into angular:main Nov 13, 2025
26 of 28 checks passed
@ok7sai
Copy link
Member Author

ok7sai commented Nov 13, 2025

This PR was merged into the repository. The changes were merged into the following branches:

ok7sai added a commit that referenced this pull request Nov 13, 2025
@ok7sai
refactor(aria/grid): rework cell widget and wrap continuous behavior (#…
fe50566 
…32290)

* refactor(aria/grid): rework cell widget and wrap continuous behavior

* refactor: data-active-control attribute

* refactor: remove onNavigate output

(cherry picked from commit 3d74ca6)
@ok7sai ok7sai deleted the ng-aria-grid branch November 13, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ok7sai @wagnermaciel