fix: avoid Anthropic tool-history requests without tools #8248
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Comment on lines
+160
to
+175
| // Restrict workaround to Anthropic/Claude routes to avoid unintended behavior changes. | ||
| const isAnthropicLike = | ||
| input.model.providerID === "anthropic" || | ||
| input.model.api.id.includes("anthropic") || | ||
| input.model.api.id.includes("claude") || | ||
| input.model.api.npm === "@ai-sdk/anthropic" | ||
|
|
||
| const effectiveTools: Record<string, Tool> = | ||
| isAnthropicLike && noToolsProvided && hasToolHistory | ||
| ? { | ||
| _dummy: tool({ | ||
| description: "Placeholder tool for API compatibility", | ||
| inputSchema: jsonSchema({ type: "object", properties: {} }), | ||
| }), | ||
| } | ||
| : tools |
Collaborator
There was a problem hiding this comment.
There are a LOT of providers that don't have this issue... and having no tools is intentional...
ideally this would be strictly limited to litellm
Should not apply to anthropic, openrouter, vertex, bedrock, etc etc
Collaborator
There was a problem hiding this comment.
ik this is minor and most likely the llm wont call the dummy tool but I don't love this change affecting everyone
Collaborator
There was a problem hiding this comment.
Maybe just make it if "litellm" in provider id (or similar)
Author
There was a problem hiding this comment.
reasonable, this is not for all. i will update for only "litellm".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Anthropic/LiteLLM proxies rejecting requests when message history contains tool calls but
toolsparam is empty.Adds a dummy tool when:
tool-callortool-resultThe dummy tool is excluded from
activeToolsso it won't be invoked.Fixes fix: Anthropic via LiteLLM/proxies rejects requests with tool history but no tools param #8246
Relates to LiteLLM error: Anthropic doesn't support tool calling without tools= param specified #2915
How did you verify your code works?
bun run tsc --noEmitpasses