fix: Replace empty catch blocks with proper error logging #8271
+21
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 7 instances of empty catch blocks across 5 files that were silently swallowing errors, making debugging difficult and potentially masking critical failures.
Changes Made
1.
packages/opencode/src/session/message-v2.tsLogimport for error logging2.
packages/opencode/src/cli/cmd/tui/component/prompt/index.tsxLogimport for error logging3.
packages/opencode/src/session/retry.tsLogimport for error logging4.
packages/opencode/src/pty/index.tsLog.create({ service: "pty" }))5.
packages/opencode/src/server/mdns.tsLog.create({ service: "mdns" }))Technical Details
Logutility throughout codebaseLog.Default.debug()and existing logger instances appropriatelyTesting
Impact
Files Changed
Verification
Related Issues
Addresses technical debt identified in codebase review where empty catch blocks were silently swallowing errors, making production debugging nearly impossible.